SonarCloud reports issues

[iluwatar]

The project is using SonarCloud static code analysis. The latest results are showing that it has found several blockers and critical severity code smells (major, minor, and info level we ignore). In this task, those are fixed or marked as false positives. To mark false positives, SuppressWarnings annotation should be used in code as explained in the linked documentation.

Links:
Blocker and critical severity code smells in SonarCloud
Sonar false positives

---

Note: When Submitting a PR please provide a hyperlinked list of all the issues that you are issuing a fix for. See this example

[ykayacan]

Can I take this issue?

[iluwatar]

Sure @ykayacan

[iluwatar]

This issue is free for taking again.

[ImLynxie]

I would like to take this issue.

[ImLynxie]

Through out checking the files causing issues on SonarCloud, I've encountered test cases that are not properly named to the functionality that they are to be tested against.

Example`

In-correct naming convention of a test method.

@Test void test() throws Exception { App.main(new String[]{}); }

Correct naming convention of a test method.

@Test public void shouldExecuteAppWithoutException() { assertDoesNotThrow(() -> App.main(null)); }

A test method should describe what its testing directly in the naming, I will rename the test cases that I find throughout the refactoring process to match proper convention rules, if the test case is understandable as to what it's testing, but I would encourage that these test cases be looked at and properly named for other contributors making changes to certain files that the test cases test against, otherwise it causes a lot of confusion as to whether said contributor is testing the right thing.

[iluwatar]

Ok @ToxicDreamz, assigned to you. I agree with your comment regarding test naming.

[ImLynxie]

I've already finished with the issue.

Request to run another SonarCloud report after merging, to see what else remains, and whether or not they can be modified so issues do not come up again.

[iluwatar]

13 blockers and 24 criticals remaining: https://sonarcloud.io/project/issues?id=iluwatar_java-design-patterns&resolved=false&severities=BLOCKER%2CCRITICAL

[iluwatar]

HotelDaoImpl.java seems to be one of the hotspots we should fix: https://sonarcloud.io/component_measures?id=iluwatar_java-design-patterns&selected=iluwatar_java-design-patterns%3Atransaction-script%2Fsrc%2Fmain%2Fjava%2Fcom%2Filuwatar%2Ftransactionscript%2FHotelDaoImpl.java&view=list

[anuragagarwal561994]

@iluwatar happy to be back again :)
Can I help with this issue?

[iluwatar]

Ok, go ahead @ShivanshCharak

[ShivanshCharak]

Raised a pr for the following Critical code smell
#1960

please also review
a minor code smell
#1959 (comment)

[S7sRuss]

Can I help?

[iluwatar]

Ok @S7sRuss, thanks for the help