Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Lombok to records #2807

Open
iluwatar opened this issue Feb 25, 2024 · 7 comments
Open

Migrate from Lombok to records #2807

iluwatar opened this issue Feb 25, 2024 · 7 comments

Comments

@iluwatar
Copy link
Owner

See the article https://medium.com/thefreshwrites/migrating-from-lombok-to-records-in-java-fa2ece28bd68

Acceptance criteria

  • Lombok code replaced with Java records
@JabezBrew
Copy link
Contributor

JabezBrew commented Feb 25, 2024

Assign to me @iluwatar

@shiyayonn
Copy link

Hi @iluwatar, I would also like to work on this issue, but I have a question regarding the use of Slf4j annotation, it's not mentioned in the article you posted, should we leave it as is? It is heavily used in code
image

@iluwatar
Copy link
Owner Author

iluwatar commented Mar 9, 2024

I think we can leave Slf4j out of scope in this issue. The idea is just to start using records, not to get rid of Lombok totally.

@shiyayonn if you'd like to work on this, please coordinate with @JabezBrew so that duplicate work can be avoided.

@shiyayonn
Copy link

Hi @JabezBrew are you still working on this issue? I would love to help you on this! Thanks!

@JabezBrew
Copy link
Contributor

JabezBrew commented Mar 11, 2024

Hi @JabezBrew are you still working on this issue? I would love to help you on this! Thanks!

@shiyayonn sure. you can take half of the architectures. I'll take the other half.

@leiferksn
Copy link
Contributor

I've recently done that for one of my own projects and I would gladly help you reduce your lombok usage 😄 Let me know if I can take over some part of the work.

Copy link

stale bot commented May 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label May 18, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants