Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: cdk generate project template should refer to fluvio stable release #3785

Open
digikata opened this issue Dec 18, 2023 · 5 comments
Open
Labels
bug Something isn't working no-issue-activity no-stale Opt-out of closing issue due to no activity

Comments

@digikata
Copy link
Contributor

What happened

cdk generate generates a project where the Cargo.toml contains fluvio (and fluvio related crate) dependency of:

fluvio = { git = "https://github.com/infinyon/fluvio", rev = "SHAHASH" }
fluvio-connector-common = { git = "https://github.com/infinyon/fluvio", rev = "SHAHASH", features = ["derive"]}

Expected behavior

The generated project should create

How to reproduce it (as minimally and precisely as possible)
Steps to reproduce the behavior:

  1. cdk generate <projectname>
  2. cat projectname/Cargo.toml

Environment (please complete the following information):
cdk

Additional context
The immediate fix could be to change the template to refer to a stable fluvio.

fluvio = "0.11"

The Cargo.lock would maintain the specific patch version.

@digikata
Copy link
Contributor Author

An additional related item to decouple the connector dep references is that fluvio-connector-common also referenced, is not a released crate, so it can't be referenced via crates.io

@pinkforest
Copy link
Contributor

fwiw fluvio-connector-common probably / maybe / maybahps could be re-exported via fluvio via additive feature flag e.g.

fluvio = { vers = "X.Y", features = ["connector-common"] }

That way can ensure the compatibility across types etc.

@digikata
Copy link
Contributor Author

We definitely have a set of options with different tradeoffs to consider. Export as a feature adds adds bulk to the fluvio crate, but is nice that it keeps everything in sync for the end dep user.

Copy link

Stale issue message

@pinkforest
Copy link
Contributor

fyi

Would be perhaps good to test with a dummy connector that release ref from git works upon stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working no-issue-activity no-stale Opt-out of closing issue due to no activity
Projects
None yet
Development

No branches or pull requests

2 participants