Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: 1.1x speed #454

Open
mergesort opened this issue Jun 11, 2018 · 4 comments
Open

Feature Request: 1.1x speed #454

mergesort opened this issue Jun 11, 2018 · 4 comments

Comments

@mergesort
Copy link

I'd like something a bit faster than the normal speed, but not quite as fast as 1.25x.

Thanks a lot!

@insidegui
Copy link
Owner

At this point I think we should allow the user to determine their preferred speeds since this is not the first time someone has asked for another speed option 😅

@mergesort
Copy link
Author

Sounds even better to me. 😄

@allenhumphreys
Copy link
Collaborator

@insidegui Breaking this down a little bit, I can render the button image dynamically, but need to know what font should be used.

Would user preferences be synced? Should they be stored in user defaults or maybe a special speed configuration plist. Since PlayerUI is kind of its own thing, should I provide a subclass of NSUserDefaults or stick another singleton onto UserDefaults (i.e. UserDefaults.playerDefaults) to govern PlayerUI?

I know I should really keep working on the downloads window.... but this one struck my fancy this morning.

@insidegui
Copy link
Owner

@allenhumphreys Maybe use NSUbiquitousKeyValueStore? If you'd like to make this more generic, maybe provide a way for the app to inject something that conforms to a protocol so the player doesn't have to know about iCloud vs. user defaults...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants