Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation hierarchy for related session #561

Open
nik6018 opened this issue Jun 8, 2019 · 3 comments
Open

Navigation hierarchy for related session #561

nik6018 opened this issue Jun 8, 2019 · 3 comments

Comments

@nik6018
Copy link

nik6018 commented Jun 8, 2019

When I am n level deep after going from related session of one video to another, there is no way of going back to n-1 screen. Either I have to search the video or again manually go through from one related video to another.

Can't a back button like the Mac App Store be implemented here? Don't know if it will be appropriate for a Mac App.

Also can a favourite mechanism be implemented for related sessions where I don't have to go to the detail page of a session to favourite it, just like I can do in the left side bar? request moved to #568

@insidegui
Copy link
Owner

Not sure about the navigation thing, it's a complex problem to solve. Any ideas @allenhumphreys ?

Also can a favourite mechanism be implemented for related sessions where I don't have to go to the detail page of a session to favourite it, just like I can do in the left side bar?

This is something we should definitely think about implementing.

@allenhumphreys
Copy link
Collaborator

I think adding the favorite directly in the related session link should be a separate issue since they’re 2 features.

Without looking, I think it’d be possible to implement a super simple navigation history by piggy backing on the infrastructure that drives the related session linking. I don’t think it’d be a simple feature but I also don’t think it’d require major refactoring or re-writing of existing code.

@allenhumphreys
Copy link
Collaborator

Feature description

  1. A standard AppKit NSSegmentedControl will be added to the title bar area
    a. The forward and back buttons will be inactive at appropriate times
  2. A back stack will be maintained
    a. It will be modeled by a tab and optionally a selected session
    b. The stack will behave similar to finder
    c. Items will be added to the stack when the tab it changed manually
    d. Items will be added to the stack when a session is navigated to
    e. Navigating to the item on top of the back stack will remove it (to prevent unnecessary items)
    f. Changing selection within a tab won't add an item to the back stack
    g. interplay with filtering should be explored, favor simplicity when in doubt
  3. A forward stack will be maintained
    a. Clicking back will move the current state into the forward stack
    b. Adding an item to the back stack will clear the forward stack

This covers most of my thoughts on the interactions, I think we'll be able to leverage existing coordinator methods to power all this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants