Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasource: Discuss meaning of bool field #2826

Open
mauriciovasquezbernal opened this issue May 9, 2024 · 0 comments
Open

datasource: Discuss meaning of bool field #2826

mauriciovasquezbernal opened this issue May 9, 2024 · 0 comments

Comments

@mauriciovasquezbernal
Copy link
Member

Fields can be booleans, however the exact meaning of this field is not clear. There are two different options:

  1. Bool() == false means all bytes are set to 0 (implemented in 11bf3b6)
  2. Bool() == false means the first byte is set to (changed in 78a0153)

There was some discussion on #2796 we we never reached a full agreement and decided to move forward with the PR to avoid blocking others. However we need to be sure we're all aligned on this.

cc @flyth

@alban do you have any opinions on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant