Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an update_network function to reduce code duplication #931

Open
sash-a opened this issue Aug 29, 2023 · 0 comments
Open

Create an update_network function to reduce code duplication #931

sash-a opened this issue Aug 29, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@sash-a
Copy link
Contributor

sash-a commented Aug 29, 2023

Feature

Because of the fact that we have a separate actor and critic, we need to update both networks separately, this is leading to a lot of code duplication, for example here.

We should make a function: update_network and then call this twice to update the network to reduce the code duplication.

@sash-a sash-a added the enhancement New feature or request label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant