Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to python 3.11 #941

Open
sash-a opened this issue Sep 19, 2023 · 4 comments
Open

Upgrade to python 3.11 #941

sash-a opened this issue Sep 19, 2023 · 4 comments
Labels
maintenance General improvements/optimisations priority/low

Comments

@sash-a
Copy link
Contributor

sash-a commented Sep 19, 2023

Please describe what needs to be maintained?

Upgrade python version, we are on 3.9, which is almost 3 years old at this point.

Big reason for this is the discussion in #940 about having generic named tuples, which isn't possible in 3.9 or 3.10. But 3.11 brings other benefits also.

I have tested this locally and it worked out of the box.

@sash-a sash-a added the maintenance General improvements/optimisations label Sep 19, 2023
@sash-a
Copy link
Contributor Author

sash-a commented Sep 20, 2023

Solution we found in #940 was from typing_extensions import NamedTuple. Solves the immediate issue, although upgrading to 3.11 would still be nice, just not as urgent

@sash-a
Copy link
Contributor Author

sash-a commented Nov 20, 2023

I have tested python 3.12 and it seems to work without issue, we should drop support for 3.9 (and possibly 3.10 also) soon as it is nearing end of life.

@liamclarkza
Copy link
Contributor

I think this is a good idea - it would be nice to have language support for pattern matching too!

@WiemKhlifi
Copy link
Contributor

Maybe along with this upgrade the pre-commit #1036 or move to ruff as suggested here #1002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General improvements/optimisations priority/low
Projects
None yet
Development

No branches or pull requests

3 participants