Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add max_count to limit profile post downloads #2271

Closed

Conversation

Mesheo
Copy link

@Mesheo Mesheo commented May 20, 2024

Motivation for this change

👋 Hi! I made this PR to make it possible to control the quantity of posts downloaded.
The core method self.posts_download_loop() already has this functionality, but the external calling functions like instaloader.download_profiles() were not adjusted to receive or pass this argument further.

The completeness of this change

  • is it just a proof of concept? No
  • Is the documentation updated (if appropriate)? Yes
  • Do you consider it ready to be merged or is it a draft? Yes
  • Can we help you at some point? I dont think so... but its my first PR so let me know anything

@Mesheo Mesheo marked this pull request as ready for review May 20, 2024 21:12
@aandergr
Copy link
Member

This is not a fix, and as such should be based on upcoming/v4.12. The docstring comment should then be amended by a versionchanged directive documenting that the feature has been added in v4.12. The parameter description for the max_count parameter mentions the --count option, however, --count does not (and must not) affect max_count for download_profiles().

@Mesheo Mesheo changed the base branch from master to upcoming/v4.12 June 3, 2024 11:14
tanducmai and others added 11 commits June 3, 2024 08:38
The comment function in the command line options documentation and the main program file has been edited to state that it now requires login. This change was crucial as the additional requests to Instagram server made for each post necessitate user authentication.
Fix GitHub Actions Node.js deprecation warnings.

Use actions/setup-python cache where appropriate.
@Mesheo Mesheo force-pushed the minor-fix-rate-limiting-downloadposts branch from fe473a4 to 147884c Compare June 3, 2024 11:39
@Mesheo Mesheo changed the base branch from upcoming/v4.12 to master June 3, 2024 11:42
@Mesheo Mesheo changed the base branch from master to upcoming/v4.12 June 3, 2024 11:43
@Mesheo
Copy link
Author

Mesheo commented Jun 3, 2024

I made a mess trying to rebase this PR and will just create a new one pointing to the upcoming/v4.12 branch
Sorry for that and thanks for the feedback

@Mesheo Mesheo changed the base branch from upcoming/v4.12 to master June 3, 2024 11:56
@Mesheo Mesheo closed this by deleting the head repository Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_posts() with limit
6 participants