IndexOutOfBoundsException in legacy webapp region search

[aturling]

The legacy (non-BlueGenes) webapp produces an IndexOutOfBoundsException error when the number of regions searched for is exactly one less than the number of items displayed per page.

Steps to reproduce:

1. Navigate to the region search page, for example: https://legacy.humanmine.org/humanmine/genomicRegionSearchAction.do
2. Select Organism and Feature type(s)
3. Enter exactly 9 regions, for example:

2:10000001..11000000
2:11000001..12000000
2:12000001..13000000
2:13000001..14000000
2:14000001..15000000
2:15000001..16000000
2:16000001..17000000
2:17000001..18000000
2:18000001..19000000

4. Click Search - note that the results table does not appear
5. Change page size from 10 to 25 - note that the results table now appears
6. Change page size back to 10 - should now get an internal error

You can get the same error by repeating the above steps with 24 regions and changing the page size to 25, etc.

The error in the log is:

ERROR org.intermine.web.struts.InterMineExceptionHandler  [] - java.lang.IndexOutOfBoundsException: toIndex = 10
        at java.util.ArrayList.subListRangeCheck(ArrayList.java:1014)
        at java.util.ArrayList.subList(ArrayList.java:1006)
        at org.intermine.bio.web.logic.GenomicRegionSearchService.convertResultMapToHTML(GenomicRegionSearchService.java:1385)
        at org.intermine.bio.web.struts.GenomicRegionSearchAjaxAction.getData(GenomicRegionSearchAjaxAction.java:234)

I believe the issue is with the strict inequality in genomic_region_search_results_default.js, here: https://github.com/intermine/intermine/blob/dev/bio/webapp/src/main/webapp/model/genomic_region_search/genomic_region_search_results_default.js#L152

Changing ">" to ">=" in line 152 seems to fix this.