Documents marked "Sent" even when email failed to be dispatched by Invoice Ninja.

[shurushetr]

Setup

• Version: v5.8.26-C155
• Environment: Docker

Interface

• Flutter: []
• React: []
• Both: [V]

Checklist

• Can you replicate the issue on our v5 demo site https://demo.invoiceninja.com or https://react.invoicing.co/demo? - Yes
• Have you searched existing issues? - Yes
• Have you reported this to Slack/forum before posting? - Yes - https://forum.invoiceninja.com/t/failed-email-notification/15025
• Have you inspected the logs in storage/logs/laravel.log for any errors? - Yes.

Describe the bug

Invoices/Quotes and other emailed items are being marked as "Sent" even if they weren't actually sent and logs have records of failed emails. Confusing user experience and creating not needed follow up calls with clients about invoice not being paid, or quotes not viewed for example.

Steps To Reproduce

Send any email within Invoice Ninja with faulty email server config - dispatch will fail but the document will be marked as "Sent"

Expected Behavior

When email dispatch failed - change status of the document to "Failed to email" or something similar.

Additional context

Would be great to have logs showing what had failed to email - without it, significant amount of time wasted in search of a document with problems.

Screenshots

Logs

[turbo124]

Once an invoice is committed to being "sent" the balance increments to the amount owing. This defines the status change from "Draft" to "Sent".

Perhaps sent isn't the best terminology in cases where the email fails to send,

[shurushetr]

But also, I can't get over the fact that a draft document will be dispatched to a customer with the "send time" setting.

[shurushetr]

Sounds like in this case, status "Sent" describes the change in balance, not an actual dispatch of information to the client.
The balance can be changed without client receiving any information about it (mark it sent). Probably Accrual should be used instead of "Sent".

And then for sent/failed sent a separate trigger from mailer?

[shurushetr]

so drafts are scheduled when saved? (not marked as sent)

[turbo124]

Just to be clear. When you schedule an invoice to be sent, is it sent regardless of its status. The two are mutually exclusive.

[shurushetr]

Ok, I understand that, what is considered "scheduled invoice to be sent"?
For example:

• Create new invoice
• Fill out client, due date
• Insert first line - Parts with price
• Insert second - shipping with price.
• insert third line - labor - NO PRICE, since it has to be checked later and inserted here. So this is not finished invoice.
• Save in DRAFT state.

After I save the invoice in draft - would it be scheduled to be sent?

[turbo124]

A scheduled invoice can only be considered 1 of the three options:

1. It is scheduled using the schedule service.
2. It is a recurring invoice that is generated
3. It is an active invoice that has reminders configured, those reminders are "scheduled"

Anything else is not scheduled.

[shurushetr]

So it seems like adding the status for "Failed Dispatch" would take a fair amount of work?
What about adding log events to the "Dashboard => System Logs" with references included (like "invoice number 31028973 failed to dispatch with via email"?

[shurushetr]

[shurushetr]

=) Maybe there is a simple solution here too.

[shurushetr]

v5.8.38-C156

Still no notification about failed emails... Dashboard logs don't include any email notifications at all...

[turbo124]

not sure, are you using queue's?

The system will insert the correct failed activity if you are using queue's

[shurushetr]

I've changed it to SYNC as suggested here - https://forum.invoiceninja.com/t/sending-out-mail/11921/12
when I had issues with Google SMTP refusing mail with 421 error.