-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong 'output' path #2342
Comments
thanks.. you helped me find where they were going. I have shortened my path to accommodate the problem. |
I believe this is an issue with how Storage is being used in guide.ts. In the constructor, Storage is called with no arguments: Lines 21 to 28 in a1ca6b3
Looking at the code for @freearhey/core (src/storage.ts), if a root directory path is passed it is used, otherwise it uses the current working directory:
When the save call is made: Lines 45 to 55 in a1ca6b3
it gets mapped to _write in Storage which adds the path to the root directory:
which is the working directory the script was called from. I believe the fix would be to utilize Path in @freearhey/core to get the dirname of the output option and pass that to the Storage constructor. From what I can tell if it is just a filename/pattern or references a relative path it should default to the current working directory as a base, so in theory it should be mostly backwards compatible. Edit: as a workaround you might be able to use Edit 2: I confirmed |
Describe your issue
epg directory
command
the file should be downloaded to
/download/xml/id.xml
but it saved to/home/epg/download/xml/id.xml
The text was updated successfully, but these errors were encountered: