Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Enhance workloadSelector #50619

Open
DerekTBrown opened this issue Apr 22, 2024 · 0 comments
Open

[Feature Request] Enhance workloadSelector #50619

DerekTBrown opened this issue Apr 22, 2024 · 0 comments

Comments

@DerekTBrown
Copy link

(This is used to request new product features, please visit https://github.com/istio/istio/discussions for questions on using Istio)

Describe the feature request

  • workloadSelector is the means by which to specify (among other things) which pods EnvoyFilters apply to. It currently only supports filtering based on pod label.
  • This feature request is to extend workloadSelector to support several additional functionalities:
    1. Filtering based on an inclusion/exclusion list. (eg. it doesn't have X label).
    2. Filtering based on the namespace name. This prevents users from having to deploy the same EnvoyFilter into multiple namespaces.
    3. Filtering based on namespace-level labels. This makes it easier for users to implement something like a per-service opt-out.

Describe alternatives you've considered
Currently, there are three options for configuring EnvoyFilter targeting:

  1. Apply to all Envoys everywhere in the cluster (by deploying EnvoyFilter in the root namespace).
  2. Deploy the same config into each namespace you want to deploy the filter into (this is not DRY).
  3. Deploy on a per-pod basis (and presumably use some sort of admission controller to make sure pods are tagged appropriately).

These aren't ergonomic for the core usecases for EnvoyFilter, which mostly fall on a per-namespace opt-in/opt-out basis.

Affected product area (please put an X in all that apply)

[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants