Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istioctl ztunnel-config improvement #50655

Open
ilrudie opened this issue Apr 23, 2024 · 2 comments
Open

istioctl ztunnel-config improvement #50655

ilrudie opened this issue Apr 23, 2024 · 2 comments
Assignees
Labels

Comments

@ilrudie
Copy link
Contributor

ilrudie commented Apr 23, 2024

(This is used to request new product features, please visit https://github.com/istio/istio/discussions for questions on using Istio)

Describe the feature request

istioctl x ztunnel-config doesn't have much in the way of verbosity control. it would be good to be able to add this for a more refined ux

Describe alternatives you've considered

Affected product area (please put an X in all that apply)

[X] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[X] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

#50654 (comment)

@MorrisLaw
Copy link
Contributor

When we refer to verbosity control, what are we referring to exactly @ilrudie ?

We have log level verbosity commonly used throughout ztunnel-config (and istioctl) in general. But we don't have any examples of a --verbosity N command (where N is the number/level of verbosity).

@ilrudie
Copy link
Contributor Author

ilrudie commented May 13, 2024

take a look at the linked pr. it might help with understanding where this comes from. basically we have internal mechanisms for verbose or not verbose in terms of the command output already implemented but afaik we don't expose those to the user. It came up because I hardcoded verbose to true in one spot in the PR in order to get more useful summary information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants