Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentelemetry tracing bug: status code always unset #50195

Closed
2 tasks done
Frapschen opened this issue Apr 2, 2024 · 5 comments · Fixed by #50722
Closed
2 tasks done

opentelemetry tracing bug: status code always unset #50195

Frapschen opened this issue Apr 2, 2024 · 5 comments · Fixed by #50722
Labels
area/extensions and telemetry

Comments

@Frapschen
Copy link

Frapschen commented Apr 2, 2024 •
edited by istio-policy-bot

Is this the right place to submit this?

  • This is not a security vulnerability or a crashing bug
  • This is not a question about how to use Istio

Bug Description

I have reviewed some Istio spans and it appears that the Status code does not change when an HTTP request fails. I expect the Status code to adhere to the Status semantic conventions.

origin issue: envoyproxy/envoy#32114

Version

istio 1.17.8

Additional Information

No response
@zirain
Copy link
Member

zirain commented Apr 2, 2024

1.17.8 is EOL for a long time, please update to latest and retry. If it's still exist, envoy need a fix.

@Frapschen
Copy link
Author

1.17.8 is EOL for a long time, please update to latest and retry. If it's still exist, envoy need a fix.

thanks, I will try the latest

@miroswan
Copy link

@Frapschen did this resolve your issue?

@zirain
Copy link
Member

zirain commented Apr 13, 2024

this seems need code change in envoy, will take a look later.

@zirain zirain mentioned this issue Apr 19, 2024
Merged
@zirain
Copy link
Member

zirain commented Apr 28, 2024

fixed by envoyproxy/envoy#33674, will land in istio v1.23.

@zirain zirain closed this as completed Apr 28, 2024
@zirain zirain reopened this Apr 28, 2024
@zirain zirain mentioned this issue Apr 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/extensions and telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

release notes for 50195 zirain/istio
4 participants
@miroswan @zirain @Frapschen @istio-policy-bot