Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.20] Fix service entry merge #50774

Closed
istio-testing opened this issue May 1, 2024 · 1 comment
Closed

[release-1.20] Fix service entry merge #50774

istio-testing opened this issue May 1, 2024 · 1 comment
Assignees

Comments

@istio-testing
Copy link
Collaborator

Manual cherrypick required.

#50711 failed to apply on top of branch "release-1.20":

Applying: Fix service entry merge
Applying: Add test
Applying: add release notes
Applying: better test
Applying: working except stable ordering
Using index info to reconstruct a base tree...
M	pilot/pkg/serviceregistry/serviceentry/conversion.go
M	pilot/pkg/xds/cds_test.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/xds/cds_test.go
Auto-merging pilot/pkg/serviceregistry/serviceentry/conversion.go
Applying: sort
Applying: Refactor
Using index info to reconstruct a base tree...
M	pilot/pkg/model/endpointshards.go
M	pilot/pkg/model/push_context.go
M	pilot/pkg/model/service.go
M	pilot/pkg/serviceregistry/serviceentry/conversion.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/serviceregistry/serviceentry/conversion.go
Auto-merging pilot/pkg/model/service.go
Auto-merging pilot/pkg/model/push_context.go
Auto-merging pilot/pkg/model/endpointshards.go
Applying: fix tests
Using index info to reconstruct a base tree...
M	pilot/pkg/model/endpointshards.go
M	pilot/pkg/model/push_context.go
M	pilot/pkg/model/service.go
M	pilot/pkg/serviceregistry/serviceentry/conversion.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/serviceregistry/serviceentry/conversion.go
Auto-merging pilot/pkg/model/service.go
Auto-merging pilot/pkg/model/push_context.go
CONFLICT (content): Merge conflict in pilot/pkg/model/push_context.go
Auto-merging pilot/pkg/model/endpointshards.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0008 fix tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@zirain
Copy link
Member

zirain commented May 8, 2024

fixed by #50776

@zirain zirain closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants