Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider constructors for heavy custom types to make heap allocation consistent #1009

Closed
bleggett opened this issue May 2, 2024 · 0 comments · Fixed by #1082
Closed

Consider constructors for heavy custom types to make heap allocation consistent #1009

bleggett opened this issue May 2, 2024 · 0 comments · Fixed by #1082
Assignees
@jaellio
Labels
good first issue Indicates a good first issue for new contributors

Comments

@bleggett
Copy link
Contributor

bleggett commented May 2, 2024

Spinoff of #1002 (comment)

Rather than Boxing or Arcing at point of use, we could simply add news/constructors to our heavier custom types so that they are heap-allocated by default as an opinion at time of declaration, to keep things consistent for all usages.
@bleggett bleggett added the good first issue Indicates a good first issue for new contributors label May 2, 2024
@jaellio jaellio self-assigned this May 3, 2024
@howardjohn howardjohn mentioned this issue May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaellio jaellio

Labels
good first issue Indicates a good first issue for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor build_requests howardjohn/ztunnel
2 participants
@bleggett @jaellio