Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headless service support #554

Closed
nmittler opened this issue Jun 19, 2023 · 5 comments · Fixed by #1056
Closed

Add headless service support #554

nmittler opened this issue Jun 19, 2023 · 5 comments · Fixed by #1056
Assignees
@howardjohn
Labels
lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically.

Comments

@nmittler
Copy link
Contributor

nmittler commented Jun 19, 2023 •
edited

Ztunnel doesn't currently support headless services. This will be needed by the DNS proxy, however.

The initial DNS proxy PR (#536) ignores headless services for now.
@hzxuzhonghu
Copy link
Member

Why not supported even without dns proxy?

DNS is resolved by core-dns and ztunnel fetches Workload(Address) by dst ip

@nmittler
Copy link
Contributor Author

Why not supported even without dns proxy?

@hzxuzhonghu I'm not sure what your point is here, exactly. If you're just saying that we should implement headless services in ztunnel independent of the DNS proxy work, that's fine. However, DNS proxy is one concrete use case where it's needed.

@howardjohn
Copy link
Member

howardjohn commented Jun 20, 2023 •
edited

I think we can change the proto to stop using VIP and start using service key. That is basically what it is today anyways

cc @kdorosh

@hzxuzhonghu
Copy link
Member

Sorry I mean IIUC ztunnel can send request to headless service currently. For ztunnel there is no much diff, today ztunnel outbound is based on upstream workload/svc. And in headless case, definitely it is based on workload.

@nmittler nmittler self-assigned this Jun 26, 2023
@howardjohn howardjohn assigned howardjohn and unassigned nmittler May 15, 2024
@istio-policy-bot
Copy link

🚧 This issue or pull request has been closed due to not having had activity from an Istio team member since 2023-06-21. If you feel this issue or pull request deserves attention, please reopen the issue. Please see this wiki page for more information. Thank you for your contributions.

Created by the issue and PR lifecycle manager.

@istio-policy-bot istio-policy-bot added lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. labels May 15, 2024
@howardjohn howardjohn reopened this May 15, 2024
@howardjohn howardjohn mentioned this issue May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@howardjohn howardjohn

Labels
lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dns: fix headless service handling howardjohn/ztunnel
4 participants
@howardjohn @nmittler @hzxuzhonghu @istio-policy-bot