Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

mlem deploy flyio fails due to wrong fly.toml generated #657

Open
aguschin opened this issue Apr 26, 2023 · 0 comments
Open

mlem deploy flyio fails due to wrong fly.toml generated #657

aguschin opened this issue Apr 26, 2023 · 0 comments
Labels
bug Something isn't working deploy Related to model deployment p1-high High priority

Comments

@aguschin
Copy link
Contributor

aguschin commented Apr 26, 2023

Under the hood MLEM calls flyctl launch to generate fly.toml config for deployment.

It happens, that sometimes flyctl launch generates very short fly.toml instead of the expected one. That file doesn't have an instruction for fly to work with 8080 port (or whichever one we specify) and after deployment service doesn't respond to requests.

example of "short"/"wrong" fly.toml:

app = "art-expert-retry2"
primary_region = "lax"

example of "long"/"correct" one:

app = "art-expert-retry2"
kill_signal = "SIGINT"
kill_timeout = 5
primary_region = "lax"
processes = []

[env]

[experimental]
  auto_rollback = true

[[services]]
  http_checks = []
  internal_port = 8080
  processes = ["app"]
  protocol = "tcp"
  script_checks = []
  [services.concurrency]
    hard_limit = 25
    soft_limit = 20
    type = "connections"

  [[services.ports]]
    force_https = true
    handlers = ["http"]
    port = 80

  [[services.ports]]
    handlers = ["tls", "http"]
    port = 443

  [[services.tcp_checks]]
    grace_period = "1s"
    interval = "15s"
    restart_limit = 0
    timeout = "2s"

Quick search didn't give me any hint whether we simply don't specify some argument for flyctl launch or whether this is a bug in fly we need to wait a fix for.

@aguschin aguschin added bug Something isn't working deploy Related to model deployment p1-high High priority labels Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working deploy Related to model deployment p1-high High priority
Projects
None yet
Development

No branches or pull requests

1 participant