Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant property wrappers in GitHub user search #12

Open
glassomoss opened this issue Jul 16, 2019 · 0 comments
Open

Redundant property wrappers in GitHub user search #12

glassomoss opened this issue Jul 16, 2019 · 0 comments

Comments

@glassomoss
Copy link

glassomoss commented Jul 16, 2019

I've looked into GitHub user search project and found out that views contain unnecessary property wrappers (@State). According to WWDC sessions those shouldn't appear in such context. I removed them and search continued working correctly. I assume it'd be helpful removing them from repo to prevent newbies in Combine study on project with mistakes. Also I found out that project contains parts that are not used at all. I guess I can provide PR if needed)

Thank you for this amazing repo btw! I also speak Russian if that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant