Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sources #31

Closed
SwordKing69 opened this issue Mar 15, 2023 · 7 comments
Closed

Sources #31

SwordKing69 opened this issue Mar 15, 2023 · 7 comments

Comments

@SwordKing69
Copy link

Hii there I used this scraper and it was good but it will be more better if you please provide option to manually add sources for proxies.
Like different sources files http,socks4,socks5 so that we can have more proxies from our own desired url/website.
Please look into this.

@iw4p
Copy link
Owner

iw4p commented Mar 16, 2023

Hi
It's a scraper, which is designed for specific websites. So it can not scrape every proxy website until I implement it because each site has different tags.
You can give me websites and I'll add them.

@realnovak
Copy link

why don't you add a regex for ip:port instead, saves you the trouble.

@iw4p
Copy link
Owner

iw4p commented Jun 23, 2023

why don't you add a regex for ip:port instead, saves you the trouble.

Because I'm not just good at regex, :D kidding, but having a well-structured scraper is better than just using regex in my prospective. Regex is my last solution always. Do you think regex is a better option?

@realnovak
Copy link

Well, sure why not? it can barely mess with your well structured code as it only consists of 5-6 lines of extra code (for simpler terms), without requiring any fancy structuring to the code.

@iw4p
Copy link
Owner

iw4p commented Jun 24, 2023

It can be a good solution, but I have to test it. If you have time you can do a sample on your fork maybe? And we can check the time for doing benchmarks.

@realnovak
Copy link

sure thing, I'll let you know once i have done it

@iw4p
Copy link
Owner

iw4p commented Jun 25, 2023

Thank you!

@iw4p iw4p closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants