Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build using git sources based on latest Rust master #231

Open
jethrogb opened this issue Dec 16, 2018 · 0 comments
Open

Can't build using git sources based on latest Rust master #231

jethrogb opened this issue Dec 16, 2018 · 0 comments

Comments

@jethrogb
Copy link
Collaborator

jethrogb commented Dec 16, 2018 •
edited

In #228, in Blueprint::from and Blueprint::push, several invocations of Path::exists were added. Since git sources are not available on the filesystem, this has broken builds using git sources after rust-lang/rust#56092 was merged. Since tools/rustc-std-workspace-core will not be found on disk, the necessary [patch] section will not be inserted. (This only applies if your installed rust-src component is not up to date, but see #230)
This was referenced Dec 16, 2018
Open
Closed
Merged
@jethrogb jethrogb changed the title Can't build using git sources based on latest Rust master Can't build using git/path sources based on latest Rust master Dec 28, 2018
@jethrogb jethrogb changed the title Can't build using git/path sources based on latest Rust master Can't build using git sources based on latest Rust master Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jethrogb