Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.26 has a subtle breaking change #342

Open
assafmo opened this issue Jul 5, 2022 · 1 comment
Open

v0.3.26 has a subtle breaking change #342

assafmo opened this issue Jul 5, 2022 · 1 comment

Comments

@assafmo
Copy link

assafmo commented Jul 5, 2022

Hi guys, please see this commit message on our project's repo: scrtlabs/SecretNetwork@a8f623f

Pin xargo to v0.3.25

As xargo v0.3.26 contains breaking changes, specifically this: v0.3.25...v0.3.26diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L147-R148 which caused an error[E0463]: can't find crate for "core" error when building

This is because of the change to the search path of sysroot. You might want to also tag v0.3.26 as v0.4.0.

Cc @reuvenpo

@RalfJung
Copy link
Collaborator

RalfJung commented Jul 5, 2022

Your link is broken, I assume you mean this one. (EDIT: ah fun, github breaks this link)

That diff comes from #338. That's just a doc change though, it does not change behavior. This folder it mentions (src in the Rust repository) has been wrong for years (ever since the Rust standard library was moved to library), and I finally fixed the docs.

Whatever problem you are seeing is definitely not caused by #338.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants