Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random #define in utmp.h breaks expat build #1093

Open
mulle-nat opened this issue Jan 19, 2024 · 0 comments
Open

Random #define in utmp.h breaks expat build #1093

mulle-nat opened this issue Jan 19, 2024 · 0 comments

Comments

@mulle-nat
Copy link

There is a #define ACCOUNTING 9 in libc/runtime/utmp. Unfortunately libexpat uses this identifier in xmlparse.c:

typedef unsigned long long XmlBigCount;
typedef struct accounting {
  XmlBigCount countBytesDirect;
  XmlBigCount countBytesIndirect;
  int debugLevel;
  float maximumAmplificationFactor; // >=1.0
  unsigned long long activationThresholdBytes;
} ACCOUNTING;

This define could be deleted I think, since it seems to be used nowhere (searching with github through the cosmopolitan repository).

In a previous version I also stumbled on cosmopolitan doing a #define I which tripped some Objective-C code up. (found it in imag.internal.h). I am not sure, if that's still bothering me, since I #undef it since...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant