Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting bug when NaN values exist #635

Open
GauravBhagchandani opened this issue Mar 20, 2024 · 3 comments
Open

Sorting bug when NaN values exist #635

GauravBhagchandani opened this issue Mar 20, 2024 · 3 comments

Comments

@GauravBhagchandani
Copy link

GauravBhagchandani commented Mar 20, 2024

Describe the bug
Sorting seems to break when there's a NaN value in the series

Expected behavior
Values should be sorted in ascending order

Screenshots
image

@Harmedino
Copy link

what part of the code needs to be fixed a clue please

@steveoni
Copy link
Member

You can check here

let sortedIdx = utils.sortArrayByIndex(rangeIdx, this.values, this.dtypes[0]);

And you can dropna and then sort

@GauravB159
Copy link

I need the rows with NaN though, because the other columns have usable values. It would make sense if the NaN values were all together somehow, at the start or the end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants