Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale UI components with font-size using em units, remove hardcoded px units #198

Open
benjamingwynn opened this issue Apr 29, 2024 · 2 comments

Comments

@benjamingwynn
Copy link

The font-size is currently hardcoded for a lot of styles. As 98.css isn't readable at high resolutions (see #56) it would be useful to be able to define an explicit font size and have components scale correctly accordingly.

For example, instead of the font-size: 12px hardcoded on the body and font-size: 11px declared for button, label, input, legend [...] we can define a font size of 0.91667em (11/12 ~= 0.91667) and remove the font-size on body.

I have a prototype of this but not with all the sizes yet, I'm happy to finish it, write up a PR and make it official if this is useful!

@tazjin
Copy link

tazjin commented Jun 2, 2024

I have a prototype of this but not with all the sizes yet, I'm happy to finish it, write up a PR and make it official if this is useful!

It definitely would be!

@benjamingwynn
Copy link
Author

@tazjin hey, I never got around to finishing the conversion from px units to em, so I don't want to write a full PR (yet?); but have made a good dent in the basic components on the em-units branch - I also made some other potentially useful styling changes on the main branch which I found worked better specifically with Safari

Fork is available at https://github.com/benjamingwynn/98.css if you're interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants