Pass the new player to nextTrack to allow mixed playlist playback #5488
Conversation
Signed-off-by: Kevin G <kevin@myplaceonline.com>
|
dmitrylyzo
added
bug
Cloudflare Pages deployment
|
|
It crashes here (the player has been killed on the stop event): jellyfin-web/src/components/playback/playbackmanager.js Lines 2989 to 2990 in edc70fe IMO, passing a new player breaks the logic - getting the previous source from the new player. We probably need to change this check: to !newPlayer.
This: to newPlayer.
And kill the player after the event is triggered: jellyfin-web/src/components/playback/playbackmanager.js Lines 3409 to 3414 in edc70fe So the previous player will be alive until it is no longer needed (for the next item). In fact, our playback code is a mess and requires a lot of refactoring. At first glance, we should also kill the player on error, but this is probably handled by |
|
Makes sense, thanks. I'll try it out when I have a chance. |
Changes
When a playlist is stopped (e.g. track finishes), if the player for the next playlist item is different, then this new player needs to be used as otherwise the current player has been nulled out.
Issues
Fixes #5486