Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since v10.9, a lot of my cover art for media is displayed in a square which crops out a lot of the image. #5560

Closed
maru801 opened this issue May 19, 2024 · 6 comments
Labels
bug Something isn't working
Milestone

Comments

@maru801
Copy link

maru801 commented May 19, 2024

Describe The Bug
Before v10.9, all the cover art for my shows were properly displayed in a rectangle, with only some image resolutions causing the cover art display to actually become a square (500px x 500px cover art for example).

Now, a lot of my cover art is for some reason becoming a square. Not all of my covers have this happen, but it appears to be random. I don't know what image resolutions will cause this.

Here's pictures describing what's happening:
This is a show cover that's a square
This is the actual image that's being displayed

Example of how they're supposed to be

Steps To Reproduce

  1. Look around your libraries and look for cover art that became squares when displayed.

Expected Behavior
Media cover art should be rectangles instead of being shrunk to a square.

System (please complete the following information):

  • Platform: Linux
  • Browser: Chrome, Firefox
  • Jellyfin Version: 10.9.2
@maru801 maru801 added the bug Something isn't working label May 19, 2024
@maru801 maru801 changed the title Since v10.9, a lot of my cover art for media is displayed in a square which crops out a lot of the images. Since v10.9, a lot of my cover art for media is displayed in a square which crops out a lot of the image. May 19, 2024
@Debouelesmorts
Copy link

I'm experiencing the same problem since upgrading from version 10.8.13 to 19.2.

@kandykarter
Copy link

I have this issue as well, so far only noticed on one film, corrected by switching to a similar poster with a more "standard" size, 1500x1000.

Screenshot from 2024-05-20 10-37-25

@Debouelesmorts
Copy link

I have several thousand films and unlike @kandykarter this bug affects my covers by the hundreds.

@scampower3
Copy link
Member

What are the aspect ratios of the problematic images?

@enter-a-random-username
Copy link

enter-a-random-username commented May 22, 2024

I had the issue as well. Maybe the ratio got changed, i changed to a value that worked much better for me. I use the react experimental UI in under client settings.

diff --git a/src/components/cardbuilder/cardImage.ts b/src/components/cardbuilder/cardImage.ts
index aeaaaaa22..aeaaaaa29 100644
--- a/src/components/cardbuilder/cardImage.ts
+++ b/src/components/cardbuilder/cardImage.ts
@@ -21,7 +21,7 @@ export function buildCardImage(
             shape = CardShape.Banner;
         } else if (item.PrimaryImageAspectRatio >= 1.33) {
             shape = CardShape.Backdrop;
-        } else if (item.PrimaryImageAspectRatio > 0.71) {
+        } else if (item.PrimaryImageAspectRatio > 0.81) {
             shape = CardShape.Square;
         } else {
             shape = CardShape.Portrait;

I think square is much more uncommon and the ratio needs to be really close, so i prefer the poster

@thornbill thornbill added this to the v10.9.3 milestone May 25, 2024
@1hitsong
Copy link
Member

Fixed by #5587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants