New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can the sum overflow? #2

Open

dilbert-ro opened this issue Aug 19, 2017 · 2 comments

dilbert-ro commented Aug 19, 2017

pretty-algorithms/algorithms/search/binary-search/binary-search.ts

Line 12 in e97dcb7

const mid = Math.floor((end + start) / 2);

Owner

jiayihu commented Aug 19, 2017

It's very unlikely that you have numbers so huge to overflow , especially on the client

utkarshbhatt12 commented Aug 23, 2017

You can use (start + ((end - start) / 2) to avoid the overflow, in case that happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment