Skip to content
This repository has been archived by the owner on Feb 26, 2023. It is now read-only.

Blank value in client Meta Properties causes key/value mismatch #454

Open
toadstule opened this issue Aug 8, 2019 · 2 comments
Open

Blank value in client Meta Properties causes key/value mismatch #454

toadstule opened this issue Aug 8, 2019 · 2 comments
Labels
bug help wanted

Comments

@toadstule
Copy link

toadstule commented Aug 8, 2019 •
edited

In my client nomad config, I have:

  "client": {
    "enabled": true,
    "max_kill_timeout": "10m",
    "meta": {
      "key_a": "value_a",
      "key_b": "value_b",
      "key_c": "",
      "key_d": "value_d",
      "key_e": "value_e"
    },

This results in the UI client page displaying:

Meta Properties
key_a: value_a
key_b: value_b
key_c: value_d
key_d: value_e
key_e:
@toadstule
Copy link
Author

toadstule commented Aug 8, 2019 •
edited

Possibly a regression from when this line was removed/changed:

https://github.com/jippi/hashi-ui/blame/aba2f405802a6ea0df0b427162ae6f64b78c65fd/frontend/src/components/MetaPayload/MetaPayload.js#L33

@kshpytsya
Copy link

The following html snippet illustrates what happens:

<html>
    <head>
        <style>
            dt::after { content: " : " }
            dt
            {
                float: left;
                clear: left;
            }
        </style>
    </head>
    <body>
        <dl>
            <dt>A1</dt><dd>B1</dd>
            <dt>A2</dt><dd></dd>
            <dt>A3</dt><dd>B3</dd>
        </dl>
    </body>
</html>

I am not an html expert so cannot suggest a fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jippi @kshpytsya @toadstule