Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side menu tab bar overlaps with the presenting vc's tab bar during transitions. #692

Open
ElrB opened this issue May 12, 2022 · 1 comment

Comments

@ElrB
Copy link

ElrB commented May 12, 2022

I have read the guidelines for contributing and I understand

  • [true ] My issue is happening in the latest version of SideMenu (older versions are no longer maintained).
  • [true ] My issue was not solved in the README.
  • [true ] My issue can not be answered on stackoverflow.com.
  • [true ] My issue is not a request for new functionality that I am unwilling to build and contribute with a pull request.
  • [true ] My issue is reproducible in the demo project.

Describe the bug
Presented menu table view's tab bar over laps with the presenting view controller's tab bar during presentation/dismissal transitions.

To Reproduce
Steps to reproduce the behavior:
import SideMenu

var menu: SideMenuNavigationController? - (global variable)
setupSideMenu() - (called in view did load)

private func setupSideMenu() {
menu = SideMenuNavigationController(rootViewController: PopyaPlusViewController())
SideMenuManager.default.leftMenuNavigationController = menu
}

  • (Method to present menu vc)
    @IBAction func popyaPlusBtnTapped(_ sender: UIButton) {
    guard let menu = menu else { return }
    present(menu, animated: true, completion: nil)
    }

  • (Main methods in menu table vc)
    override func viewDidLoad() {
    super.viewDidLoad()
    tableView.register(UINib(nibName: "SideMenuTableViewCell", bundle: nil), forCellReuseIdentifier: "Cell")
    }

    override func viewWillAppear(_ animated: Bool) {
    super.viewWillAppear(animated)
    self.navigationController?.navigationBar.isTranslucent = true
    setupTableView()
    }

    func setupTableView() {
    navigationItem.leftBarButtonItem = UIBarButtonItem(image: UIImage(systemName: "info.circle"), style: .plain, target: self, action: #selector(infoBtnTapped))
    tableView.backgroundColor = .white
    tableView.showsVerticalScrollIndicator = false
    tableView.allowsSelection = false
    self.tabBarController?.tabBar.isTranslucent = true
    }

Expected behavior
I expect the tab bars overlapping behaviour not to happen as it seem to prevent taps on the presenting vc tab bar items not to be recognised (sometimes).

Screenshots
image_123986672-3

image_123986672-2

image_123986672

Additional context
I am using Xcode 13.1, - iPhone XR

@ElrB
Copy link
Author

ElrB commented May 16, 2022

I noticed that my issue was only occurring if I set my tab bar to be isTranslucent = false. This issue happens with any other VC that has its tab bar isTranslucent = true but presenting a VC that has its tab bar isTranslucent = false. Any reason why this would happen? And solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant