Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] notch macbook support. #1

Open
jiengup opened this issue Feb 1, 2024 · 27 comments
Open

[Feature Request] notch macbook support. #1

jiengup opened this issue Feb 1, 2024 · 27 comments
Labels
enhancement New feature or request
Milestone

Comments

@jiengup
Copy link

jiengup commented Feb 1, 2024

Beneficial application!
Do you consider designing for a notch MacBook's built-in screen?
When we have so many menu bar icons, we can't see all the icons using ice's hidden strategy nowadays.
It's like:
On my 27 inch monitor:
image
But on built-in screen:
image
because of Apple's genius notch design.

@jiengup jiengup changed the title [Feature Request] notch [Feature Request] notch macbook support. Feb 1, 2024
@jordanbaird
Copy link
Owner

This is something that could definitely be supported, but I don't have access to a MacBook with a notch to be able to work on it. I'll add it to the roadmap for the time being, and hopefully it can happen soon.

@jordanbaird jordanbaird added the enhancement New feature or request label Feb 2, 2024
jordanbaird added a commit that referenced this issue Feb 2, 2024
@y-u-s-u-f
Copy link

I think it would be cool if we got an option like Bartenders "Bar" - Photo:
BartenderBar

@jordanbaird
Copy link
Owner

I think it would be cool if we got an option like Bartenders "Bar" - Photo: BartenderBar

This is also on the roadmap, but can't be implemented until I work out how to implement individual menu bar item movement. Right now, Ice can only move items in sections. I have a semi-working implementation, but it's quite complicated with lots of failure points that need to be addressed.

@merken
Copy link

merken commented Feb 19, 2024

I'm waiting for notch support as well. Once this issue gets resolved, I'll try this app out!

@loranger
Copy link

Notch support would definitely be great: I miss some app icons behind it 😞

@Xytronix
Copy link

Xytronix commented Apr 10, 2024

For those additional menu bars, its only possible to add them to the menu bar and then to be opened as far I know. This isn't that fluent, but a solution for Macbooks with a Notch

@Xytronix
Copy link

Beneficial application! Do you consider designing for a notch MacBook's built-in screen? When we have so many menu bar icons, we can't see all the icons using ice's hidden strategy nowadays. It's like: On my 27 inch monitor: image But on built-in screen: image because of Apple's genius notch design.

If its possible to show menu bar items on the left, then the width of the notch has to be recorded.

@blu-e-man
Copy link

Now that Bartender is exhibiting strange behavior, notch support from ICE would be great.

@HaigNalbandian
Copy link

Please move this to the top of the backlog. Many people want to move from Bartender at the moment, but this is a must-have.

@yonatankremer
Copy link

the people have spoken

@nweii
Copy link

nweii commented Jun 5, 2024

Another space-efficient approach for when the notch prevents all extra items from showing could be for those extra items to replace the unhidden items when revealed, instead of showing in addition to those items. That creates some extra space to show hidden icons. I use it this way in bartender currently.

@jordanbaird
Copy link
Owner

I hear everyone. This is definitely in the pipeline. The main thing blocking this is that Ice needs to be able to move individual menu bar icons. When an icon is clicked in the secondary bar, it needs to be temporarily moved from whichever section it is in to the visible section so it can show its menu. I have this mostly working, but there are certain apps, such as BetterTouchTool, that block the proper events from being sent to the items. A temporary workaround could be to disable the feature when BetterTouchTool is running.

@jonasjelonek
Copy link
Sponsor

Is there anything we can support you with in this, besides the financial support?
This is currently the only thing that unwillingly prevents me from moving from Bartender to Ice, since I also have the Notch.

Maybe an alpha/beta release would be something? Since you said it's mostly working we could test it, and discover and sort out remaining issues.

@merken
Copy link

merken commented Jun 7, 2024

I would also like to volunteer as beta tester if that helps. MBP 14 with notch.
Would it not be as simple as providing a spacer at the coordinates of the notch? Are there any API's to leverage here?

@MoKhajavi75
Copy link

I can help in beta testing too. MBP 14 (M3 - Sonoma 14.5)

@HaigNalbandian
Copy link

Also willing to test on my notched 14" MB Air and on a 27" 1440p monitor

@gingerbeardman
Copy link

Would it not be as simple as providing a spacer at the coordinates of the notch? Are there any API's to leverage here?

My thoughts exactly. If so, we would need to figure out if the current display has a notch (hopefully as simple as an api call) and how big it is (are they all the same?)

@fifafu
Copy link

fifafu commented Jun 7, 2024

@jordanbaird developer of BetterTouchTool here, what kind of events are you seeing blocked by BTT? Would be happy to fix or help with that. (Bartender also seems to be able to do this while BTT is running, but I haven't checked the exact events it uses yet)

@kud
Copy link

kud commented Jun 7, 2024

It would be amazing to have this feat. I want to get rid of Bartender asap. 🙏

@jordanbaird
Copy link
Owner

@fifafu Thank you for the help! I haven't tracked down exactly which of these it is, but it's one (or all) of mouse down, mouse dragged, and mouse up. It results in an event tap that listens for these events timing out. Would you be able to email me at jordanbaird.dev@gmail.com so we can talk in more detail about what's going on?

@fifafu
Copy link

fifafu commented Jun 7, 2024

Sure I'll ping you!
But isn't the general problem that you can only target items that are "on-screen" with these events? I can easily programmatically move around the items that are visible, but the hidden ones that are pushed off screen by either setting the status item length to a high value or because there are just too many, these I'm unable to access using standard events.

@jordanbaird
Copy link
Owner

@fifafu I've found a workaround for that. But yes, that was a problem early on.

@jordanbaird jordanbaird pinned this issue Jun 8, 2024
@jordanbaird jordanbaird added this to the 0.10.0 milestone Jun 8, 2024
@jordanbaird
Copy link
Owner

Good news -- @fifafu and I were able to solve the remaining problems with individual item movement. All that's left now is to implement the secondary bar

@MoKhajavi75
Copy link

We really appreciate your efforts @jordanbaird & @fifafu ✌🏻

@dwt
Copy link
Sponsor

dwt commented Jun 10, 2024

@jordanbaird as a fellow developer (though mostly python these days) I'd be glad to help test and send logs or do experiments. Yes my ObjC/Swift is rusty, but I should be able to do some basic experiments.

@ThisIsMissEm
Copy link

Just gonna through this out there: if you change your screen size to a non-standard size the stupid top notch goes away, and you can see everything.

i previously tried to use TopNotch to remove it, and that stopped working when I upgraded to M3 / Sonoma, but I found that workaround after a lot of googling

@dwt
Copy link
Sponsor

dwt commented Jun 12, 2024

I'm using the tool zNotch temporary hide/show the notch, together with this handy shell script:

$ cat bin/toggle-notch
#!/usr/bin/env sh
open 'xyz.kondor.znotch://v1/manage?action=toggle'

That gives me access to all my menu items in a pinch until ice has better support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests