Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Any change in monitors while Mac is asleep removes styling #53

Open
1 task done
fastnlight0 opened this issue Apr 11, 2024 · 5 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@fastnlight0
Copy link

fastnlight0 commented Apr 11, 2024

Check existing issues

  • I have checked existing issues and believe that my issue is not a duplicate

Description

I have my menu bar styled. When I put my Mac to sleep, change my monitor configuration (close Mac lid, unplug a monitor, etc), then wake it up again (eg. by re-opening the lid), my menu bar is back to normal (unstyled). When I restart the Ice app, or do something to re-trigger the menu bar style (eg. enter and exit full screen on an app or change monitor count), the menu bar re-styles itself.

Even if the monitors are the same when I turn off my Mac and turn it back on (eg. sleep mac, unplug monitor, replug same monitor, wake up Mac), the issue still occurs. If no change in monitors occurs, Ice keeps it's styling when I wake my Mac back up. Closing or opening the lid counts as a monitor change.

Steps to Reproduce

  1. Style your menu bar
  2. Put Mac to sleep
  3. Make any change to monitor setup (you can even go back to the original setup before waking your Mac back up)
  4. Observe your unstyled menu bar

Ice Version

0.8.0 (latest version at time of writing)

macOS Version

14.4.1 (23E224) (latest version at time of writing)

Screenshots

No response

@fastnlight0 fastnlight0 added the bug Something isn't working label Apr 11, 2024
@fastnlight0 fastnlight0 changed the title [Bug]: Any change is monitors while Mac is asleep removes styling [Bug]: Any change in monitors while Mac is asleep removes styling Apr 12, 2024
@dajabe
Copy link

dajabe commented May 27, 2024

Something similar also exhibits when you have multiple desktops setup and you switch between the desktops. It shows unstyled for a moment before apply the style a moment later.

I thought the styling feature was cool but since I use multiple desktops and I'm switching between them constantly this would be distracting watching the styling removed and the reapplied over and over.

I figured this might be related so just adding a note here. If it's useful I'll open a separate issue

@jordanbaird
Copy link
Owner

@dajabe This is the expected behavior. See issue #58. Although, I see that Bartender works around it, so maybe the memory issues I mentioned there wouldn't be a problem.

@fastnlight0 Apologies for the delayed response on this. I haven't had a second monitor to test with for a while. I just got a new one, so I'll see what I can do.

@dajabe
Copy link

dajabe commented May 28, 2024

Ah that is unfortunate i should have gone through your closed issues as well. I suspect this one will be a similar situation.

I have a macbook with notch and two screens. If you want any additional testing feel free to ping me and I'll see what I can do.

@jordanbaird
Copy link
Owner

@dajabe I'll do some research to see if offscreen windows take up memory. Now that I'm thinking about it, macOS is probably well enough optimized that it might not be a problem. The menu bar would still flash the first time you switch to a desktop, but after that, we can retain the window so that it doesn't do it continuously.

@dajabe
Copy link

dajabe commented May 29, 2024

@jordanbaird I don't know much about how this works in the system and the main feature I wanted is the hiding so I'm definitely low priority 😄

If it helps this bug though I was just noting that there are some similarities in how this bug exhibits and the styling only updating once the screen is rendered. So maybe when it comes out of wake it's hitting a different hook than you currently use to redraw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants