Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeling #30

Open
jordansinger opened this issue Jul 12, 2020 · 2 comments
Open

Modeling #30

jordansinger opened this issue Jul 12, 2020 · 2 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@jordansinger
Copy link
Owner

How should we be thinking about modeling the views, especially those that differ by platform and as the repo grows over time?

Could imagine the #if method getting messy.

As I was building this in the first place, I imagined making a struct to hold each grouping and an array of views inside of it. Curious if there are other suggestions and if doing this might be overkill?

@jordansinger jordansinger added the question Further information is requested label Jul 12, 2020
@ivanglushko
Copy link

What if you were to use Modules for each platform? That way it won't be messy and shared code (views) can be shared and reused. But it needs a little hustle to implement.

@Nef10
Copy link
Collaborator

Nef10 commented Jul 13, 2020

I agree that we should have a better way than all this #if os() in the middle of the code.

We also should come up with a good way to handle the different modifiers. E.g. in the ProgressView has a CircularProgressViewStyle which we only show on watchOS, although it is available on all Platforms. We don't show it because on the other platforms it is the default style.

@majouji majouji added the help wanted Extra attention is needed label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants