Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use form for the demo #1

Open
adityanandanx opened this issue Apr 20, 2024 · 4 comments · May be fixed by #2
Open

Use form for the demo #1

adityanandanx opened this issue Apr 20, 2024 · 4 comments · May be fixed by #2

Comments

@adityanandanx
Copy link

Use form for the demo so as to enable checkProfanity mutation to be run when the user presses the enter key.

@adityanandanx adityanandanx linked a pull request Apr 20, 2024 that will close this issue
@PrivFelixKniest
Copy link

No necessary need for a form here probably, you could also just catch the enter action and submit the Function that way, though I believe that this change would not provide a ton of value for the algorithm itself

@adityanandanx
Copy link
Author

adityanandanx commented Apr 20, 2024

@PrivFelixKniest yes. This feature is not necessary but still counts as UX improvement. Using form is more accessible and will still work if there are more fields added in the future.

I am still exploring the algorithm. I felt like this is a nice feature to have and took hardly 5 minutes to implement so I opened a PR. Doesn't hurt to have it 😃

@PrivFelixKniest
Copy link

yup, I can look over the PR aswell if you want to tag me, I guess josh has to review it anyways though

@PrivFelixKniest
Copy link

Ah wait yeah I found it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants