Skip to content
This repository has been archived by the owner on Mar 13, 2020. It is now read-only.

Save list of incoming transactions for current address during snapshot #10

Open
joshirio opened this issue Apr 22, 2018 · 1 comment
Open
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@joshirio
Copy link
Owner

joshirio commented Apr 22, 2018

Currently the history of an address is saved to the wallet file permanently only after an outgoing transaction, which implies that the address will never be used again, since that would trigger an address reuse.

Currently, if a snapshot happens, an unspent address will lose its incoming transactions history, since nodes drop all transactions after a snapshot.

It makes sense to always store the latest transaction in the wallet file under a temporary position that is added to the wallet file permanently if a snapshot has been detected.

It is necessary to find a reliable way to detect a snapshot, because sometimes broken nodes report zero transactions for a given address.

@joshirio joshirio added the enhancement New feature or request label Apr 22, 2018
@joshirio joshirio added this to the 1.2 milestone Apr 22, 2018
@joshirio joshirio self-assigned this Apr 22, 2018
@joshirio
Copy link
Owner Author

joshirio commented Apr 30, 2018

Issue: after current snapshot some CarrIOTA nodes that haven't upgraded show old transactions while other upgraded nodes return no transaction, this means checking for an empty tx list to detect snapshots is not reliable because the next node could be showing the old list again causing multiple entries for the same transactions.

Maybe there's another way. A possibility would be to save every new incoming transaction based on bundle hash to detect unique transactions and to avoid duplicates.

@joshirio joshirio modified the milestones: 1.2, 1.3 Mar 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant