Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(modeling): changed imports to directly import from single files when possible #1267

Merged
merged 2 commits into from
Jul 2, 2023
Merged

refactor(modeling): changed imports to directly import from single files when possible #1267

merged 2 commits into from
Jul 2, 2023

Conversation

z3dev
Copy link
Member

@z3dev z3dev commented Jul 2, 2023 •
edited

These changes attempt to eliminate any kind of circular dependencies in imports. See #1258

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

@z3dev z3dev linked an issue Jul 2, 2023 that may be closed by this pull request
V3 : eliminate circular dependencies #1258
Open
@z3dev z3dev requested review from platypii and hrgdavor July 2, 2023 01:13
platypii
platypii approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good.

I also confirmed that this branch does fix the pnpm run build rollup circular dependency warning. 👍

@z3dev z3dev merged commit 639d7af into V3 Jul 2, 2023
2 checks passed
@z3dev z3dev deleted the fix-modeling-imports branch August 19, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platypii platypii platypii approved these changes

@hrgdavor hrgdavor Awaiting requested review from hrgdavor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V3 : eliminate circular dependencies
2 participants
@z3dev @platypii