Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Rule]: no-unbound-method #3709

Closed
sampattuzzi opened this issue Mar 12, 2024 · 1 comment
Closed

[New Rule]: no-unbound-method #3709

sampattuzzi opened this issue Mar 12, 2024 · 1 comment

Comments

@sampattuzzi
Copy link

This rule already exists in typescript-eslint but isn't detected in the context of JSX.

class MyComponent extends React.Component<{}, {}> {
  render() {
    return <button onClick={this.handleClick}>Click me!</button>;
    //                      ~~~~~~~~~~~~~~~~  passing unbound method
  }

  handleClick(e: any) {
    alert('You clicked!');
  }
}

The rule should warn about this usage and possible duplicated the functionality of the rule in typescript-eslint: https://typescript-eslint.io/rules/unbound-method

@ljharb
Copy link
Member

ljharb commented Jun 1, 2024

The proper solution here, fwiw, is in the constructor, to do this.handleClick = this.handleClick.bind(this) - or, to do handleClick = this.handleClick.bind(this); as a class field right above the method.

Also, we already have the jsx-no-bind rule.

@ljharb ljharb closed this as completed Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants