Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Payment methods delete api to perform soft delete #4324

Open
ShankarSinghC opened this issue Apr 8, 2024 · 0 comments
Open

Make the Payment methods delete api to perform soft delete #4324

ShankarSinghC opened this issue Apr 8, 2024 · 0 comments
Labels
A-core Area: Core flows A-payment-methods Area: Payment Methods C-bug Category: Bug

Comments

@ShankarSinghC
Copy link
Contributor

-> When a payment is created with save card we store the card in the locker and also a payment method entry is created in the payment method table. And the corresponding payment_method_id will be stored in the payment_attempt table.
-> And later when that payment method is deleted, psycn is failing as we are trying to fetch the payment method data from the payment_method table in the psync flow.
-> The error occurred because of the recent change that was trying to fetch the payment method in the psync flow using the payment_method_id in the payment attempt.

So to fix this we need to make the payment methods delete api as soft delete. In this case when the payment method is deleted the payment method for the corresponding payment_method_id will be set to inactive. So that there won't be data inconsistency.

@ShankarSinghC ShankarSinghC changed the title Make the Payment methods delete api as soft delete Make the Payment methods delete api to perform soft delete Apr 8, 2024
@ShankarSinghC ShankarSinghC added A-core Area: Core flows C-bug Category: Bug A-payment-methods Area: Payment Methods labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows A-payment-methods Area: Payment Methods C-bug Category: Bug
Projects
None yet
Development

No branches or pull requests

1 participant