Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ckh-payout-scripts): fix ckh payout column types #4369

Closed
wants to merge 2 commits into from

Conversation

ivor-juspay
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fix column types for payout tables

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

payout_method_id was String type in storage and mv while the queue was Nullable(String). Changed it to Nullable(String) everywhere.
business_country fixed to LowCardinality(Nullable(String))

How did you test it?

Ran the scripts in integ, sandbox, prod envs

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ivor-juspay ivor-juspay requested a review from a team as a code owner April 16, 2024 09:11
@ivor-juspay ivor-juspay self-assigned this Apr 16, 2024
@ivor-juspay ivor-juspay linked an issue Apr 16, 2024 that may be closed by this pull request
@SanchithHegde SanchithHegde deleted the fix/ckh-payout-scripts branch April 21, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Payout Analytics] - Fix column types in ckh payout tables
2 participants