Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return 400 https status code for authentication failure #4388

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: return 400 https status code for authentication failure #4388

wants to merge 2 commits into from

Conversation

hrithikesh026
Copy link
Contributor

@hrithikesh026 hrithikesh026 commented Apr 17, 2024 •
edited

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Currently we are returning 200 status code if authentication call fails at authetication connector.

Made some changes to return 400 in case authentication call fails at authetication connector.

Other changes:
returned appropriate error message if authentication_connector_details is missing in business profile.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Manual.
Screenshot 2024-04-18 at 12 28 13 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@hrithikesh026 hrithikesh026 added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Apr 17, 2024
@hrithikesh026 hrithikesh026 added this to the April 2024 milestone Apr 17, 2024
@hrithikesh026 hrithikesh026 self-assigned this Apr 17, 2024
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner April 17, 2024 13:07
@hrithikesh026 hrithikesh026 linked an issue Apr 18, 2024 that may be closed by this pull request
[BUG] When Authentication call fails, 200 status code is returned #4391
Open
2 tasks
@sai-harsha-vardhan sai-harsha-vardhan changed the title fix: return 400 https status codefor authentication failure fix: return 400 https status code for authentication failure Apr 18, 2024
@bernard-eugine bernard-eugine modified the milestones: April 2024, May 2024 May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Awaiting requested review from Narayanbhat166

@sai-harsha-vardhan sai-harsha-vardhan Awaiting requested review from sai-harsha-vardhan

At least 2 approving reviews are required to merge this pull request.

Assignees

@hrithikesh026 hrithikesh026

Labels
C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
May 2024 Release
Development

Successfully merging this pull request may close these issues.

[BUG] When Authentication call fails, 200 status code is returned
2 participants
@hrithikesh026 @bernard-eugine