feat(FRM): Revise post FRM core flows #4394

srujanchikke · 2024-04-18T11:47:13Z

Type of Change

Description

PostAuth flow

The underlying FRM connector is invoked post authentication of the user from the bank.
If a transaction’s capture method was set to automatic, it is updated to manual for avoiding automatic capture.
Once the user completes the authentication, the underlying FRM connector is invoked. The decision whether or not to
proceed with the txn is based on the status / score returned.

Possible actions based on the status

Continue on Accept
- Continue with the transaction
Halt on Decline
- Mark the transaction as cancelled
Approve / Decline on Manual Review
- Hold the txn in manual review state. Merchants can list and review such transactions.
- If approved, payment is captured
- If declined, payment is voided

This flow works same as payments flow incase of 3ds, non 3ds, manual and auto capture for Legit payments.

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

up.sql

ALTER TABLE fraud_check 
ADD COLUMN IF NOT EXISTS payment_capture_method "CaptureMethod" NULL;

down.sql

ALTER TABLE fraud_check 
DROP COLUMN IF EXISTS payment_capture_method;

Motivation and Context

How did you test it?

Create merchant connector account with stripe and then create new merchant connector account with signifyd.

{
  "connector_type": "payment_VAS",
  "connector_name": "signifyd",
  "connector_account_details": {
    "auth_type": "HeaderKey",
    "api_key": "YOUR_API_KEY"
  },
  "test_mode": false,
  "disabled": false,
  "business_country": "US",
  "business_label": "default",
  "payment_methods_enabled": [
    {
      "payment_method": "card",
      "payment_method_types": [
        {
          "payment_method_type": "credit",
          "card_networks": [
            "Visa",
            "Mastercard"
          ],
          "minimum_amount": 1,
          "maximum_amount": 68607706,
          "recurring_enabled": true,
          "installment_payment_enabled": true
        },
        {
          "payment_method_type": "debit",
          "card_networks": [
            "Visa",
            "Mastercard"
          ],
          "minimum_amount": 1,
          "maximum_amount": 68607706,
          "recurring_enabled": true,
          "installment_payment_enabled": true
        }
      ]
    },
    {
      "payment_method": "pay_later",
      "payment_method_types": [
        {
          "payment_method_type": "klarna",
          "payment_experience": "redirect_to_url",
          "minimum_amount": 1,
          "maximum_amount": 68607706,
          "recurring_enabled": true,
          "installment_payment_enabled": true
        },
        {
          "payment_method_type": "affirm",
          "payment_experience": "redirect_to_url",
          "minimum_amount": 1,
          "maximum_amount": 68607706,
          "recurring_enabled": true,
          "installment_payment_enabled": true
        },
        {
          "payment_method_type": "afterpay_clearpay",
          "payment_experience": "redirect_to_url",
          "minimum_amount": 1,
          "maximum_amount": 68607706,
          "recurring_enabled": true,
          "installment_payment_enabled": true
        }
      ]
    }
  ],
  "metadata": {
    "city": "NY",
    "unit": "245"
  },
  "frm_configs": [
        {
            "gateway": "stripe",
            "payment_methods": [
                {
                    "payment_method": "card",
                    "payment_method_types": [
                        {
                            "payment_method_type": "credit",
                            "card_networks": [
                                "Visa"
                            ],
                            "flow": "post",
                            "action": "cancel_txn"
                        },
                        {
                            "payment_method_type": "debit",
                            "card_networks": [
                                "Visa"
                            ],
                            "flow": "post",
                            "action": "manual_review"
                        }
                    ]
                }
            ]
        }
    ]
}

TEST CASE 1 : Create legit card payment(amount =150) for both credit and debit. This should go as normal payment flow. Interchange CaptureMethod and CardType(3ds, non 3ds).
TEST CASE 2 : Create Credit(pmt type) Payment with amount equals to 15000. This should Fail the payment .

{
  "amount": 15000,
  "currency": "USD",
  "confirm": true,
  "capture_method": "manual",
  "capture_on": "2022-09-10T10:11:12Z",
  "amount_to_capture": 1500,
  "customer_id": "StripeCustomer2",
  "email": "guest@example.com",
  "name": "Bob Smith",
  "phone": "999999999",
  "phone_country_code": "+91",
  "description": "Its my first payment request",
  "authentication_type": "no_three_ds",
  "return_url": "https://google.com",
  "payment_method": "card",
  "payment_method_type": "credit",
  "payment_method_data": {
    "card": {
      "card_number": "4242424242424242",
      "card_exp_month": "10",
      "card_exp_year": "25",
      "card_holder_name": "joseph Doe",
      "card_cvc": "123"
    }
  },
  "billing": {
    "address": {
      "line1": "1467",
      "line2": "Harrison Street",
      "line3": "Harrison Street",
      "city": "San Fransico",
      "state": "California",
      "zip": "94122",
      "country": "US",
      "first_name": "joseph",
      "last_name": "Doe"
    },
    "phone": {
      "number": "8056594427",
      "country_code": "+91"
    }
  },
  "shipping": {
    "address": {
      "line1": "1467",
      "line2": "31 Sherwood Gardens",
      "line3": "31 Sherwood Gardens",
      "city": "London",
      "state": "Manchester",
      "zip": "E14 9wn",
      "country": "GB",
      "first_name": "Bob",
      "last_name": "Smith"
    },
    "phone": {
      "number": "8056594427",
      "country_code": "+91"
    }
  },
  "statement_descriptor_name": "joseph",
  "statement_descriptor_suffix": "JS",
  "metadata": {
    "udf1": "value1",
    "new_customer": "true",
    "login_date": "2019-09-10T10:11:12Z"
  },
  "order_details" : [{
        "product_name" : "gillete creme",
        "quantity" : 2,
        "amount" : 600
    },
    {
        "product_name" : "gillete razor",
        "quantity" : 1,
        "amount" : 300
    }]
}

TESTCASE 3 : Create a payment with payment method type as debit. set capture method to automatic and use same json above. Payment status should be moved to RequiresMerchantAction.
Response looks like this

{
    "payment_id": "pay_9ZgUMXOiLv35wrF6oOyd",
    "merchant_id": "merchant_1713525778",
    "status": "requires_merchant_action",
    "amount": 150000,
    "net_amount": 150000,
    "amount_capturable": 150000,
    "amount_received": 0,
    "connector": "stripe",
    "client_secret": "pay_9ZgUMXOiLv35wrF6oOyd_secret_wU5hfAMsYjBe0fXepJmj",
    "created": "2024-04-19T11:58:40.749Z",
    "currency": "USD",
    "customer_id": "StripeCustomer2",
    "customer": {
        "id": "StripeCustomer2",
        "name": "Bob Smith",
        "email": "guest@example.com",
        "phone": "999999999",
        "phone_country_code": "+91"
    },
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "manual",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "4242",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "424242",
            "card_extended_bin": "42424242",
            "card_exp_month": "10",
            "card_exp_year": "25",
            "card_holder_name": "joseph Doe",
            "payment_checks": {
                "cvc_check": "pass",
                "address_line1_check": "pass",
                "address_postal_code_check": "pass"
            },
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "London",
            "country": "GB",
            "line1": "1467",
            "line2": "31 Sherwood Gardens",
            "line3": "31 Sherwood Gardens",
            "zip": "E14 9wn",
            "state": "Manchester",
            "first_name": "Bob",
            "last_name": "Smith"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "order_details": [
        {
            "brand": null,
            "amount": 600,
            "category": null,
            "quantity": 2,
            "product_id": null,
            "product_name": "gillete creme",
            "product_type": null,
            "product_img_link": null,
            "requires_shipping": null
        },
        {
            "brand": null,
            "amount": 300,
            "category": null,
            "quantity": 1,
            "product_id": null,
            "product_name": "gillete razor",
            "product_type": null,
            "product_img_link": null,
            "requires_shipping": null
        }
    ],
    "email": "guest@example.com",
    "name": "Bob Smith",
    "phone": "999999999",
    "return_url": "https://google.com/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "next_action": null,
    "cancellation_reason": null,
    "error_code": "fraud",
    "error_message": "Refund Initiated with the processor",
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": {
        "customer_id": "StripeCustomer2",
        "created_at": 1713527920,
        "expires": 1713531520,
        "secret": "epk_22d24f1ef64b44a0b28b72a81c2b2392"
    },
    "manual_retry_allowed": null,
    "connector_transaction_id": "pi_3P7G5VD5R7gDAGff0XEZqQkO",
    "frm_message": {
        "frm_name": "signifyd",
        "frm_transaction_id": "pay_9ZgUMXOiLv35wrF6oOyd_1",
        "frm_transaction_type": "post_frm",
        "frm_status": "fraud",
        "frm_score": 497,
        "frm_reason": "SIGNIFYD_DECLINED",
        "frm_error": null
    },
    "metadata": {
        "udf1": "value1",
        "login_date": "2019-09-10T10:11:12Z",
        "new_customer": "true"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pi_3P7G5VD5R7gDAGff0XEZqQkO",
    "payment_link": null,
    "profile_id": "pro_DOE6fPp88zY1M4xUyO0H",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": null,
    "merchant_connector_id": "mca_U0XVEDfTM0JMpiv9GOr5",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-04-19T12:13:40.749Z",
    "fingerprint": null,
    "browser_info": null,
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-04-19T11:58:41.929Z"
}

/approve and /reject should hit after above step for the same payment which will mark payment as succeeded and failed by merchant.

Request curl :

curl --location --request POST 'http://localhost:8080/payments/{{payment_id}}/approve' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key:{{api_key}}' \
--data-raw '{}'

Response json :

{
    "payment_id": "pay_9ZgUMXOiLv35wrF6oOyd",
    "merchant_id": "merchant_1713525778",
    "status": "succeeded",
    "amount": 150000,
    "net_amount": 150000,
    "amount_capturable": 0,
    "amount_received": 150000,
    "connector": "stripe",
    "client_secret": "pay_9ZgUMXOiLv35wrF6oOyd_secret_wU5hfAMsYjBe0fXepJmj",
    "created": "2024-04-19T11:58:40.749Z",
    "currency": "USD",
    "customer_id": "StripeCustomer2",
    "customer": {
        "id": "StripeCustomer2",
        "name": "Bob Smith",
        "email": "guest@example.com",
        "phone": "999999999",
        "phone_country_code": "+91"
    },
    "description": "Its my first payment request",
    "refunds": null,
    "disputes": null,
    "mandate_id": null,
    "mandate_data": null,
    "setup_future_usage": null,
    "off_session": null,
    "capture_on": null,
    "capture_method": "manual",
    "payment_method": "card",
    "payment_method_data": {
        "card": {
            "last4": "4242",
            "card_type": null,
            "card_network": null,
            "card_issuer": null,
            "card_issuing_country": null,
            "card_isin": "424242",
            "card_extended_bin": "42424242",
            "card_exp_month": "10",
            "card_exp_year": "25",
            "card_holder_name": "joseph Doe",
            "payment_checks": {
                "cvc_check": "pass",
                "address_line1_check": "pass",
                "address_postal_code_check": "pass"
            },
            "authentication_data": null
        },
        "billing": null
    },
    "payment_token": null,
    "shipping": {
        "address": {
            "city": "London",
            "country": "GB",
            "line1": "1467",
            "line2": "31 Sherwood Gardens",
            "line3": "31 Sherwood Gardens",
            "zip": "E14 9wn",
            "state": "Manchester",
            "first_name": "Bob",
            "last_name": "Smith"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "billing": {
        "address": {
            "city": "San Fransico",
            "country": "US",
            "line1": "1467",
            "line2": "Harrison Street",
            "line3": "Harrison Street",
            "zip": "94122",
            "state": "California",
            "first_name": "joseph",
            "last_name": "Doe"
        },
        "phone": {
            "number": "8056594427",
            "country_code": "+91"
        },
        "email": null
    },
    "order_details": [
        {
            "brand": null,
            "amount": 600,
            "category": null,
            "quantity": 2,
            "product_id": null,
            "product_name": "gillete creme",
            "product_type": null,
            "product_img_link": null,
            "requires_shipping": null
        },
        {
            "brand": null,
            "amount": 300,
            "category": null,
            "quantity": 1,
            "product_id": null,
            "product_name": "gillete razor",
            "product_type": null,
            "product_img_link": null,
            "requires_shipping": null
        }
    ],
    "email": "guest@example.com",
    "name": "Bob Smith",
    "phone": "999999999",
    "return_url": "https://google.com/",
    "authentication_type": "no_three_ds",
    "statement_descriptor_name": "joseph",
    "statement_descriptor_suffix": "JS",
    "next_action": null,
    "cancellation_reason": null,
    "error_code": null,
    "error_message": null,
    "unified_code": null,
    "unified_message": null,
    "payment_experience": null,
    "payment_method_type": "credit",
    "connector_label": null,
    "business_country": null,
    "business_label": "default",
    "business_sub_label": null,
    "allowed_payment_method_types": null,
    "ephemeral_key": null,
    "manual_retry_allowed": false,
    "connector_transaction_id": "pi_3P7G5VD5R7gDAGff0XEZqQkO",
    "frm_message": {
        "frm_name": "signifyd",
        "frm_transaction_id": "pay_9ZgUMXOiLv35wrF6oOyd_1",
        "frm_transaction_type": "post_frm",
        "frm_status": "fraud",
        "frm_score": 497,
        "frm_reason": "SIGNIFYD_DECLINED",
        "frm_error": null
    },
    "metadata": {
        "udf1": "value1",
        "login_date": "2019-09-10T10:11:12Z",
        "new_customer": "true"
    },
    "connector_metadata": null,
    "feature_metadata": null,
    "reference_id": "pi_3P7G5VD5R7gDAGff0XEZqQkO",
    "payment_link": null,
    "profile_id": "pro_DOE6fPp88zY1M4xUyO0H",
    "surcharge_details": null,
    "attempt_count": 1,
    "merchant_decision": "approved",
    "merchant_connector_id": "mca_U0XVEDfTM0JMpiv9GOr5",
    "incremental_authorization_allowed": null,
    "authorization_count": null,
    "incremental_authorizations": null,
    "external_authentication_details": null,
    "external_3ds_authentication_attempted": false,
    "expires_on": "2024-04-19T12:13:40.749Z",
    "fingerprint": null,
    "browser_info": null,
    "payment_method_id": null,
    "payment_method_status": null,
    "updated": "2024-04-19T12:01:50.944Z"
}

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible
I added a CHANGELOG entry if applicable

…rm_core_flows

crates/router/src/core/fraud_check.rs

crates/router/src/core/fraud_check/flows/record_return.rs

…rm_core_flows

Narayanbhat166 · 2024-04-25T14:04:18Z

crates/diesel_models/src/fraud_check.rs

@@ -25,6 +26,7 @@ pub struct FraudCheck {
    pub metadata: Option<serde_json::Value>,
    pub modified_at: PrimitiveDateTime,
    pub last_step: FraudCheckLastStep,
+    pub frm_capture_method: Option<storage_enums::CaptureMethod>, // In postFrm, we are updating capture method from automatic to manual. To store the merchant actual capture method, we are storing the actual capture method in frm_capture_method. It will be useful while approving the FRM decision.


we can have a separate enum for this, just in case we might need to have different enum variants for these

Since we are using same capture method type as payment capture method, I am just renaming frm_capture_method to payment_capture_method as we discussed.

Narayanbhat166 · 2024-04-25T14:07:58Z

crates/common_enums/src/enums.rs

@@ -1176,6 +1179,7 @@ pub enum IntentStatus {
    Processing,
    RequiresCustomerAction,
    RequiresMerchantAction,
+    FrmRequiresMerchantAction,


we can use RequiresMerchantAction, this is meant to indicate that there is some MerhantAction that is required based on the frm message or some additional fields

cc: @AnandKGanesh @bernard-eugine

@Narayanbhat166 , We have introduced this status to not interfere with payments which doesn't go through FRM. In future there might decisions/actions we might take based on FrmRequiredMerchantAction status for FRM webhooks which doesn't apply for payment connectors.

cc: @kashif-m @AnandKGanesh

Right, this status is introduced for explicitly specifying the fact that merchant needs to take an FRM related action on the payment. Using existing variant RequiresMerchantAction does not give enough context about what exactly merchant needs to do. This variant is being used in one of the flows for some crypto connector cc: @srujanchikke

Having a separate variant in this case gives us full context about the type of actions that can be taken by the merchant (payment approval / cancellation in this case)

cc : @jarnura

We should not introduce the same status RequiresMerchantAction with some prefix again because the merchant wants to do something different by this. If RequiresMerchantAction is the status, then always the merchant should go to some details field or reason field, which tells what is issue and what merchant needs do.

Let's also add the feasibility to be able to list only the fraudulent transactions in payments list / filter APIs using the details / reason field

Sure, will do that it in subsequent PR

crates/router/src/core/fraud_check.rs

jagan-jaya · 2024-04-26T11:14:16Z

crates/router/src/core/fraud_check.rs

+            api_models::enums::AttemptStatus::FrmUnresolved
+        )
+    {
+        payment_data.payment_intent.status = IntentStatus::RequiresCapture; // In Approve flow, payment which has payment_capture_method "manual" and attempt status as "FrmUnresolved",


Payment data update should not happen within frm flow, only pass the suggestion on what to do with the transaction let the payments_core decide whether to consider the frm_suggestion or not. Check the update_trackers of payment_confirm

Thanks for the info, I have added new frmSuggestion and moved this logic to approve->update trackers

jagan-jaya · 2024-04-26T11:17:21Z

crates/router/src/core/fraud_check/operation/fraud_check_post.rs

    ) -> RouterResult<Option<FrmData>> {
        if matches!(frm_data.fraud_check.frm_status, FraudCheckStatus::Fraud)
-            && matches!(frm_configs.frm_action, FrmAction::AutoRefund)
+            && matches!(frm_configs.frm_action, FrmAction::CancelTxn)


We had three frm configs right?

Pre frm -> Cancel on fraud

Pre frm -> Complete transaction and mark as fraud. merchant will trigger refund if needed

Post frm -> Auto refund on fraud

Post frm -> Authorize the payment and send it for manual review. Cancel or Capture payment based on merchant decision

Why are we removing the 3 option here?

In Revised flow, We don't actually capture the payment rather we authorize the payments(Post Frm) then take a call whether to cancel/hold/capture . When merchant approves ,we capture the payment or else we cancel the payment.

…to-env * 'main' of github.com:juspay/hyperswitch: Refactor(core): remove payment_method_id from RouterData struct (#4485) fix(euclid_wasm): connector config wasm metadata update (#4460) chore(version): 2024.04.30.0 feat(user): add single purpose token and auth (#4470) feat: stripe connect integration for payouts (#2041) feat(router): handle authorization for frictionless flow in external 3ds flow (#4471) feat(FRM): Revise post FRM core flows (#4394) feat(router): send poll_config in next_action of confirm response for external 3ds flow (#4443) chore(version): 2024.04.29.0 feat(connector): [CRYPTOPAY] Report underpaid/overpaid amount in outgoing webhooks (#4468) feat(users): use cookie for auth (#4434) refactor(scheduler): join frequency and count in `RetryMapping` (#4313) refactor(required_fields): change required fields for billing address (#4258) refactor(access_token): use `merchant_connector_id` for storing access token (#4462) chore(version): 2024.04.26.0 chore(postman): update Postman collection files

* 'main' of github.com:juspay/hyperswitch: refactor(cypress): read creds from env instead of hardcoding the path (#4430) ci: fix paypal postman tests (#4501) Refactor(core): remove payment_method_id from RouterData struct (#4485) fix(euclid_wasm): connector config wasm metadata update (#4460) chore(version): 2024.04.30.0 feat(user): add single purpose token and auth (#4470) feat: stripe connect integration for payouts (#2041) feat(router): handle authorization for frictionless flow in external 3ds flow (#4471) feat(FRM): Revise post FRM core flows (#4394) feat(router): send poll_config in next_action of confirm response for external 3ds flow (#4443) chore(version): 2024.04.29.0 feat(connector): [CRYPTOPAY] Report underpaid/overpaid amount in outgoing webhooks (#4468) feat(users): use cookie for auth (#4434) refactor(scheduler): join frequency and count in `RetryMapping` (#4313) refactor(required_fields): change required fields for billing address (#4258) refactor(access_token): use `merchant_connector_id` for storing access token (#4462) chore(version): 2024.04.26.0 chore(postman): update Postman collection files

srujanchikke added 2 commits April 18, 2024 17:00

revise post frm core flows

e960e0c

Merge branch 'main' of github.com:juspay/hyperswitch into frm_core_flows

785ee7f

srujanchikke added A-core Area: Core flows A-payments Area: payments labels Apr 18, 2024

srujanchikke self-assigned this Apr 18, 2024

hyperswitch-bot bot and others added 5 commits April 18, 2024 11:47

chore: run formatter

1cb716c

fix clippy

e790e6e

Merge branch 'main' of github.com:juspay/hyperswitch into frm_core_flows

f99e030

Merge branch 'frm_core_flows' of github.com:juspay/hyperswitch into f…

164fbb8

…rm_core_flows

chore: run formatter

069baca

srujanchikke changed the title ~~feature(core): Revise post FRM core flows~~ feat(payouts): Revise post FRM core flows Apr 19, 2024

srujanchikke changed the title ~~feat(payouts): Revise post FRM core flows~~ feat(FRM): Revise post FRM core flows Apr 19, 2024

srujanchikke linked an issue Apr 19, 2024 that may be closed by this pull request

[Refactor] PostAuth FRM flow #4399

Closed

srujanchikke marked this pull request as ready for review April 22, 2024 05:08

srujanchikke requested review from a team as code owners April 22, 2024 05:08

srujanchikke requested a review from kashif-m April 22, 2024 05:09

srujanchikke added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Apr 22, 2024

kashif-m reviewed Apr 22, 2024

View reviewed changes

crates/router/src/core/fraud_check.rs Show resolved Hide resolved

crates/router/src/core/fraud_check/flows/record_return.rs Outdated Show resolved Hide resolved

srujanchikke added 3 commits April 24, 2024 15:58

refactor approve incase of manual capture

b8c5821

Merge branch 'main' of github.com:juspay/hyperswitch into frm_core_flows

c975c55

Merge branch 'frm_core_flows' of github.com:juspay/hyperswitch into f…

08da3ea

…rm_core_flows

srujanchikke requested review from a team as code owners April 24, 2024 10:30

hyperswitch-bot bot and others added 6 commits April 24, 2024 10:30

chore: run formatter

3fa28af

docs(openapi): re-generate OpenAPI specification

3190345

migrations for fraud_check and payment status

1ce254c

Merge branch 'frm_core_flows' of github.com:juspay/hyperswitch into f…

5405235

…rm_core_flows

minor change on down.sql

5f9633c

fix cargo hack by adding frm feature flag

296cee1

hyperswitch-bot bot and others added 6 commits April 24, 2024 12:40

chore: run formatter

f12d080

add transaction flow after checkout flow for pre frm

e72b38b

Merge branch 'frm_core_flows' of github.com:juspay/hyperswitch into f…

c6f46ce

…rm_core_flows

Merge branch 'main' of github.com:juspay/hyperswitch into frm_core_flows

3203ffc

resolve comments

e9fd863

minor changes

cd68352

kashif-m previously approved these changes Apr 25, 2024

View reviewed changes

minor refactor

4b290c6

srujanchikke dismissed kashif-m’s stale review via 4b290c6 April 25, 2024 13:14

Narayanbhat166 reviewed Apr 25, 2024

View reviewed changes

rename frm_capture_method to payment_capture_method in frm data

ff304d6

jagan-jaya requested changes Apr 26, 2024

View reviewed changes

srujanchikke and others added 2 commits April 26, 2024 20:08

resolve comments and revert frm_requires_merchant_action enum

5605ff3

docs(openapi): re-generate OpenAPI specification

8aebbbd

jagan-jaya approved these changes Apr 26, 2024

View reviewed changes

Merge branch 'main' into frm_core_flows

91320db

kashif-m approved these changes Apr 29, 2024

View reviewed changes

Merge branch 'main' into frm_core_flows

8cc5265

Narayanbhat166 approved these changes Apr 29, 2024

View reviewed changes

Gnanasundari24 enabled auto-merge April 29, 2024 06:47

Gnanasundari24 added this pull request to the merge queue Apr 29, 2024

Merged via the queue into main with commit 01ec7c6 Apr 29, 2024
10 of 12 checks passed

Gnanasundari24 deleted the frm_core_flows branch April 29, 2024 07:11

srujanchikke added the M-database-changes Metadata: This PR involves database schema changes label Apr 29, 2024

SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(FRM): Revise post FRM core flows #4394

feat(FRM): Revise post FRM core flows #4394

srujanchikke commented Apr 18, 2024 •

edited

Narayanbhat166 Apr 25, 2024

srujanchikke Apr 26, 2024

Narayanbhat166 Apr 25, 2024 •

edited

Narayanbhat166 Apr 25, 2024

srujanchikke Apr 26, 2024

kashif-m Apr 26, 2024

srujanchikke Apr 26, 2024

jarnura Apr 26, 2024

kashif-m Apr 29, 2024

srujanchikke Apr 29, 2024

jagan-jaya Apr 26, 2024

srujanchikke Apr 26, 2024

jagan-jaya Apr 26, 2024

srujanchikke Apr 26, 2024

feat(FRM): Revise post FRM core flows #4394

feat(FRM): Revise post FRM core flows #4394

Conversation

srujanchikke commented Apr 18, 2024 • edited

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Narayanbhat166 Apr 25, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srujanchikke commented Apr 18, 2024 •

edited

Narayanbhat166 Apr 25, 2024 •

edited