Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symmetry #57

Open
davidmerfield opened this issue May 29, 2017 · 2 comments
Open

Symmetry #57

davidmerfield opened this issue May 29, 2017 · 2 comments
Labels

Comments

@davidmerfield
Copy link

davidmerfield commented May 29, 2017

Thank you for a useful library!

A possible enhancement: incorporate compositional symmetry into the crop function? The following example from your test page would probably benefit:

screen shot 2017-05-29 at 11 22 27 am

I think this would improve the crops for architectural images in particular. If the source image scored highly for symmetry, perhaps optimize crops for symmetry too?

I haven't looked at the source for your project though, nor have I given the implementation much thought, though. Perhaps it's more effort than it's worth.

@jwagner
Copy link
Owner

jwagner commented May 29, 2017

It's definitely worth considering. I haven't spent too much time thinking about it. I guess the main challenge is trying to balance it with other constraints. Another possible issue is performance but it could also be made optional. I definitely like the idea. If you want to give it a shot be me guess. Otherwise I might give it a try at some point. :)

@davidmerfield
Copy link
Author

Seems like an interesting challenge. I'll try and find some time to take a look!

@jwagner jwagner added the idea label Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants