[Ellipsis] Try supporting Python 3.8 in the test harness matrix and in pyproject.toml #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Deploying instructor with
|
| Latest commit: |
bb063a4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6db0fdfe.instructor.pages.dev |
| Branch Preview URL: | https://ellipsis-wflow-qcghabdcubyna.instructor.pages.dev |
dosubot
bot
added
size:XS
|
@hbrooks this planned step 1, but did not implement it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue: resolves #606
Implementation:
Step 1: Add Python 3.8 to the test matrix in the GitHub workflow file
In the file
.github/workflows/test.yml, find thematrixsection understrategy(around line 14). This section currently lists the Python versions that are tested. Add "3.8" to the list ofpython-version, so it readspython-version: ["3.8", "3.9", "3.10", "3.11"].Step 2: Add Python 3.8 support in the pyproject.toml file
In the file
pyproject.toml, find thepythonsection undertool.poetry.dependencies(around line 12). This section currently lists the Python versions that are supported. Change the line topython = "^3.8"to add support for Python 3.8.Report:
Add Python 3.8 to the test matrix in the GitHub workflow file
Added Python 3.8 to the test matrix in the GitHub workflow fileAdd Python 3.8 support in the pyproject.toml file
Added Python 3.8 support in the pyproject.toml fileSomething look wrong?: If this Pull Request doesn't contain the expected changes, add more information to #606. Then, add the
ellipsis:createlabel to try again. For more information, check the documentation.