Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded helm controller does not track owner references properly #10051

Open
brandond opened this issue Apr 30, 2024 · 0 comments
Open

Embedded helm controller does not track owner references properly #10051

brandond opened this issue Apr 30, 2024 · 0 comments
Assignees
@brandond
Milestone
v1.30.2+k3s1

Comments

@brandond
Copy link
Contributor

The helm-controller refactor in in k3s-io/helm-controller#157 added a WithSetOwnerReference(false, false) to the desiredset/apply controller, but that was missed when we pulled in the refactor into k3s in #6294.

As a result, the helm controller has been failing to properly track resource ownership, and owned objects are sometimes orphaned instead of being properly deleted.
@brandond brandond changed the title Helm-controller does not track owner references properly Embedded helm controller does not track owner references properly Apr 30, 2024
@brandond brandond self-assigned this Apr 30, 2024
@brandond brandond added this to the v1.30.1+k3s1 milestone Apr 30, 2024
@brandond brandond mentioned this issue Apr 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandond brandond

Labels
None yet
Projects
K3s Development
Status: Peer Review
Milestone
v1.30.2+k3s1
Development

No branches or pull requests
2 participants
@brandond @caroline-suse-rancher