Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metric kairosdb.metric_counters is broken since 1.3.0 #667

Open
sspieker opened this issue Jul 1, 2022 · 0 comments
Open

metric kairosdb.metric_counters is broken since 1.3.0 #667

sspieker opened this issue Jul 1, 2022 · 0 comments

Comments

@sspieker
Copy link
Contributor

sspieker commented Jul 1, 2022

After upgrading K* to version 1.3.0, the metric kairosdb.metric_counters indicated a massive drop of incoming metrics/datapoints: the number decreased from 13.6 billion to 5.9 billion.

We did not see any issues in dashboards, logs etc. that indicated any problems regarding metric ingestion.

But after digging through the commits between v1.2.2 and v1.3.0, we quickly spotted the cause: commit 06641c77352d415a3767b24eb1ed00d8240fe906 removed the host tag from this metric.
This makes kairosdb.metric_counters useless in all setups with more than one KairosDB instance (which I assume would be the majority).

I understand the reason for this change (high tag cardinality can be quite painful), but this solution should be reverted nonetheless as it makes the metric useless. In my opinion, there are other ways to make the (reverted) metric more accessable, i.e. by a scheduled aggregate or using the great new feature tag_indexed_row_key_lookup_metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant