Version 1.3 sets align sampling true always

[iudeen]

As per the change here

kairosdb/src/main/java/org/kairosdb/core/aggregator/RangeAggregator.java

Line 46 in 243201c

private boolean m_alignSampling = true;

The m_alignSampling is always set true. This is causing issue when we aggregate across days. As per documentation, align_sampling is false by default.

Query without sampling set to false explicitly

{
    "metrics": [
        {
            "tags": {
                "ex": [
                    "16289"
                ]
            },
            "name": "raw",
            "group_by": [
                {
                    "name": "tag",
                    "tags": [
                        "ex"
                    ]
                }
            ],
            "aggregators": [
                {
                    "name": "sum",
                    "sampling": {
                        "value": "24",
                        "unit": "hours"
                    },
                    "align_end_time": true
                                     }
                
            ]
        }
    ],
    "plugins": [],
    "cache_time": 0,
    "start_absolute": 1672533000000,
    "end_absolute": 1672619399999
}

Results:

 "values": [
                        [
                            1672597800000,
                            0
                        ],
                        [
                            1672684200000,
                            0
                        ]
                    ]

Changing aggregators to

 "aggregators": [
                {
                    "name": "sum",
                    "sampling": {
                        "value": "24",
                        "unit": "hours"
                    },
                    "align_sampling": false,
                    "align_end_time": true
                                     }
                
            ]

Results

"values": [
                        [
                            1672619400000,
                            0
                        ]
                    ]

Which is correct!

[brianhks]

That part of the documentation is messy. I'll clean it up. The default was changed for good reason. I'll change the documentation to match what is in the code.

[iudeen]

For some reason we get two data points when we aggregate 24 hours.

Making the end time 1ms lesser solves the problem. But any idea why this behavior occurs in the latest version?

[iudeen]

Any update on this?