Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve min and max value range input validation when creating a new Execution from the UI #3698

Open
wrussell1999 opened this issue May 10, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request frontend Need some frontend code changes
Milestone

Comments

@wrussell1999
Copy link

Feature description

If I set the following properties to an INT input type, the UI doesn't show any of these when I press execute. This means as a user, I only find out the restrictions once I've pressed execute and the error pops up. It would be great to see these validation properties show up next to the input in the UI to make it clear to the user. It would also be good if an error popped up if the type a value in that isn't a valid format (for the example below, a number lower than 1 or greater than 5).

inputs:
  - id: int
    type: INT
    min: 1
    max: 5

Nothing stopped me from putting 10 in the int box:
Screenshot 2024-05-10 at 11 51 03

This sort of error would be ideal to appear in that execute page as well.
Screenshot 2024-05-10 at 11 51 35

I haven't tested this with other input types but suspect they would also benefit from this too!

@wrussell1999 wrussell1999 added the enhancement New feature or request label May 10, 2024
@anna-geller anna-geller added this to the v0.18.0 milestone May 13, 2024
@anna-geller anna-geller added the frontend Need some frontend code changes label May 13, 2024
@anna-geller anna-geller changed the title Add input validation to execute UI Improve min and max value range input validation when creating a new Execution from the UI May 13, 2024
@anna-geller
Copy link
Member

Ludo mentioned it should be possible using https://github.com/yiminghe/async-validator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Need some frontend code changes
Projects
None yet
Development

No branches or pull requests

3 participants