Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill feature for containers spun up by the Google Batch Task Runner (GcpBatchTaskRunner) #3700

Closed
wrussell1999 opened this issue May 10, 2024 · 1 comment
Assignees
Labels
backend Need some backend code changes enhancement New feature or request
Milestone

Comments

@wrussell1999
Copy link

Feature description

Last night, I was trying to kill/stop this Kestra Flow, and it's subflows. So I select 'Kill Parent and Subflows', and it said 'Queued up action', but it kept running the GCP Batch Jobs (compute VMs), I had to stop by hand.
I didn't see any logs in GCP regarding Stop Operation or anything. After I did stop by hand, it marked the Subflows as "killed"
Am I using the "kill/stop" functionality correctly? I did wait 5 minutes for it before intervening and I am going to try to test it again/later, but thought I would ask in case this was known problem. Ty 🙏

Currently, Containers spun up by a task runner will run till completion even if the Kestra server would fail or when execution would be killed.

@wrussell1999 wrussell1999 added the enhancement New feature or request label May 10, 2024
@anna-geller anna-geller added this to the v0.17.0 milestone May 13, 2024
@fhussonnois fhussonnois added the backend Need some backend code changes label May 14, 2024
fhussonnois added a commit to kestra-io/plugin-gcp that referenced this issue May 14, 2024
fhussonnois added a commit to kestra-io/plugin-gcp that referenced this issue May 14, 2024
@anna-geller anna-geller changed the title Kill feature for containers spun up by Task Runner Kill feature for containers spun up by the Google Batch Task Runner (GcpBatchTaskRunner) May 14, 2024
@anna-geller
Copy link
Member

anna-geller commented May 14, 2024

The priority is to tackle this for the GcpBatchTaskRunner.

Added separate issues for other providers to make sure we kill the infrastructure resources to avoid unnecessary costs for the user:

fhussonnois added a commit to kestra-io/plugin-gcp that referenced this issue May 14, 2024
fhussonnois added a commit to kestra-io/plugin-gcp that referenced this issue May 14, 2024
fhussonnois added a commit to kestra-io/plugin-gcp that referenced this issue May 15, 2024
fhussonnois added a commit to kestra-io/plugin-azure that referenced this issue May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Need some backend code changes enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants