Align style of Select components

[ferhoyos]

What do you want to improve?

Currently there are two types of Select components within Kiali:

• Standard Selects used mainly in Wizards

• Patternfly Selects used in the rest of the Kiali application:

It is a UX good practice to apply the same style for the same type of component, Select in this case.

What is the current behavior?

Two different Select component styles used in Kiali.

What is the new behavior?

Use the same Select component in Kiali. IMO the best choice is to follow Patternfly's style like the most of the UI elements in Kiali.

[TomasMatarazzo]

can i work on this? thx

[aljesusg]

Of course. I assigned this to you !

Welcome to Kiali community
Thanks @TomasMatarazzo

[ferhoyos]

Thanks @TomasMatarazzo! The idea is to replace all <FormSelect> (https://www.patternfly.org/components/forms/form-select, which embeds browser native select) to <Select> components (https://www.patternfly.org/components/menus/select). There are some examples of <Select> within the Kiali application you can take as reference.

Previously I would like to confirm with @fkargbo that this is the correct path to follow. Maybe for forms it is better to use native selects for some reason I ignore.

[jshaughn]

@TomasMatarazzo , Thanks! If you prefer, you can do this incrementally with multiple PRs. Please feel free to ask for guidance/review.

[ferhoyos]

Confirmed with @fkargbo that it is recommended to replace FormSelect components to unify UX style. @TomasMatarazzo, I suggest to create a first PR replacing one of the FormSelect for guidance/review. Then, you can continue with the rest of them. Thanks!